Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.I see this in the docs:
...that are stored in different field storage engines. However, this logic can be overridden in hook_entity_query().
Should this be hook_entity_query_alter() instead? Or something else?
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | d7-1705102-3-do-not-test.patch | 662 bytes | dsdeiz |
| #3 | 1705102-3.patch | 815 bytes | dsdeiz |
Comments
Comment #1
dsdeiz CreditAttribution: dsdeiz commentedChanging "Component". And "Category"? Sorry, I'm not sure if I chose the right category.
Comment #2
jhodgdonGood catch! Yes, the correct hook is hook_entity_query_alter().
Comment #3
dsdeiz CreditAttribution: dsdeiz commentedAttached.
Comment #4
jhodgdonThanks! I'll get that committed.
(By the way, I'd recommend not wasting time making D7 patches until/unless we need them. See
http://drupal.org/node/1319154#multiple-versions
for why.)
Comment #5
jhodgdonforgot status change. :)
Comment #6
dsdeiz CreditAttribution: dsdeiz commentedAh yeah. My bad. Won't happen again. The folks at #drupal-contribute also advised me this when I asked there.
Comment #7
chx CreditAttribution: chx commentedThe Drupal community never ceases to astonish me. You guys caught this? Amazing.
Comment #8
jhodgdonIt's not a *problem* that you made an extra patch, just often unnecessary work (and time you could be spending making another patch). In this case, the D7 patch was useful, because the file was a completely different name for D7. Normally, we would have wanted a clean patch to be uploaded so it could be run through the tests, but since it's a one-line docs change, I let it go this time. :)
Anyway, thanks again for contributing to Drupal! I've committed the above patches to D8 and D7.