[META] AdvAgg D7 - Aggregates Not Building [#1705352]

First I need to tell that I'm using advagg on D6 and it's working fine in various configurations. I'd love to use this on D7, too so can't wait for any stable release.
However I found that no matter how I configure advagg, it does not generate any bundles. When I click 'Rebuild AdvAgg Cache' it generates 0 files, tried Master Reset, did not help. Async mode is on, all three lock options probed without success, e.g individual css/js files show in source.

In status report it says that the theme function is not in place. Hook theme info output is:

template_preprocess
template_preprocess_page
context_preprocess_page
oursite_custom_page_title_preprocess_page
contextual_preprocess
dart_preprocess_page
imagecrop_preprocess_page
lightbox2_preprocess_page
smart_paging_preprocess_page
oursite_wysiwyg_preprocess_page
tao_preprocess_page
rubik_preprocess_page
oursite_admin_preprocess_page

Also I discovered that there is no advagg_processor in the function list compared to my D6 sites. In fact, advagg_processor isn't run at all. Since CSS/JS preprocessing is supposed to be performed at the preprocess_html stage instead of preprocess_page so theme info output might be irrelevant now.
Is there a way I can set this working?

Comments

Comment #1

vulfox CreditAttribution: vulfox commented 19 September 2012 at 18:32

Same here. I have almost all other modules turned off.

Comment #2

vulfox CreditAttribution: vulfox commented 19 September 2012 at 19:15

Notice: Undefined index: #post in advagg_admin_batch_rebuild() (line 564 in /data/domains/www.siteurl.net/sites/all/modules/advagg/advagg.admin.inc)

Comment #3

Sinan Erdem CreditAttribution: Sinan Erdem commented 9 January 2013 at 14:39

Same for me. Do we need to enable core CSS and JS aggregations to make this module work?

Comment #4

markhalliwell

English

CreditAttribution: markhalliwell commented 13 January 2013 at 08:22

Assigned:

Unassigned

» markhalliwell

This is a known issue. I actually just committed a fix so that AdvAgg is now implementing hook_process_html() instead (which is where the CSS and JS variables are located in D7). There's no more need for registry alters (I think, might need to come back on that one), so ignore that status check for now.

Also, to clarify, even though I fixed the hook being called so that it calls advagg_process() correctly now, it still isn't currently doing anything. I did this on purpose, let me explain:

Because this is a "port" to D7, a lot of the code is written specifically for D6 and relies heavily on how D6 constructed it's CSS and JS arrays, which have completely changed in D7. So it's going to take a little time to, essentially, rewrite this module from the ground up (unfortunately). In the mean time, I just have the CSS and JS function return before it does anything so that it doesn't generate a page full of errors. This allows me to focus on one thing at a time.

When I finally get aggregates being built properly, I'll post here again. Sorry for the slow update. This module kinda got put on the back burner for me.

@Sinan Erdem: In regards to enabling core CSS and JS aggregation, that is technically a no. I just committed some admin UI changes (which are now under: /admin/config/development/performance instead of it's own separate config page, just made sense) that help alleviate some confusion about how this module works in that regards. Essentially, this module should never let you see the core aggregation settings if it's being used. And in theory, if enabled, it should ignore those settings and replace core's aggregation with it's own (not sure if that was ever implemented, but it will be).

Comment #5

markhalliwell

English

CreditAttribution: markhalliwell commented 13 January 2013 at 09:35

Title:

No aggregates are built

» [META] D7 - Aggregates Not Building

I'm renaming this issue to become the meta issue for #1171546: AdvAgg - D7 Port/Re-write and placing it on the issue summary of that issue. This will need to be fixed before a stable release can be made.