I've made a bunch of changes to the 7.x-1.x branch to improve the readability of the module, coding-layout, and some presentation changes. Rather than handling a bunch of patches, would you consider pulling from my GitHub fork?

Comments

xurizaemon’s picture

xurizaemon
he/him
Location Ōtepoti, Aotearoa 🏝
CreditAttribution: xurizaemon commented
Status: Active » Needs work

@manarth, please file a patch for coding standards here, and split any other changes (eg presentation changes) to separate issues. Making a Drupal patch with Git, guide to patch contribution, etc etc. That means others in the Drupal community can use standard Drupal methods for patch testing & deployment.

(I like Github too!)

manarth’s picture

manarth CreditAttribution: manarth commented

I'm not really doing much with MailLogger, and don't really have the time to work through work from 6 months ago and split it all out into individual patches. Feel free to pull the commits from github tho, I'll leave it open as long as there's a diff against the module.

fizk’s picture

fizk CreditAttribution: fizk commented
Issue summary: View changes
Status: Needs work » Fixed

Fixed, thanks!

As xurizaemon suggested, please file separate patches when contributing back your work on Drupal.org.

  • Commit fd75498 on 7.x-1.x by fizk: 
    #1708380 manarth: Code cleanup.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.