• clean theme_breakpoints_admin_breakpoints_table
  • support ctools exportables for groups
  • support ctools exportables for breakpoints
  • add setting to manage multipliers
  • allow a user to override breakpoints set by a theme
  • make a setting 'hide overridden' breakpoints, on by default

Comments

Status:Active» Needs work

Groups are now exportable.

Question:
What to do with breakpoints in groups? Should they be automatically exported and imported when the group is exported? Or should we leave it to the user to export them?

And what if the group contains breakpoints provided by a theme or module? If we choose to export them along with the group, should they be imported with source_type 'custom' or 'module'/'theme'? And what if this module and/or theme is also enabled on the site where the group is imported? Override the breakpoints provided by that theme module (in the rare case that they have a different version of that module/theme so that these breakpoints might have different settings) or leave them as they are?

Breakpoints are now exportable.

Todo:

export and import breakpoints attached to a group when the group is exported

new feature request, allow a user to override breakpoints set by a theme
1/ on theme group page add a button 'override theme breakpoints'
2/save all theme breakpoints as custom.theme_key.
3/ change the group to use those breakpoints
4/ hide theme.theme_key breakpoints from the general view (optional)

Overriding is now possible, hiding not yet.

What to do with the following use case:
A theme that defines breakpoints is enabled.
A custom group is created and uses the theme's breakpoints.
A user overrides the breakpoints in the theme group and the theme group now uses the new (overridden) breakpoints.
What to do with the custom group that still uses the 'old/original' breakpoints if the breakpoints are now hidden?

PS:

4/ hide theme.theme_key breakpoints from the general view (optional)

Optional, as in a setting?

for that use case, don't do anything, it will be hard to predict what the user wants

regarding 4/best to make it a setting 'hide overridden' groups, on by default

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Updated issue summary.

Cleaned theme_breakpoints_admin_breakpoints_table().

Added form to manage multipliers.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Updated issue summary.

Status:Needs work» Fixed

Added setting 'hide overridden' breakpoints, on by default (need to run update.php, new field 'overridden' added to breakpoint_group table).

Issue summary:View changes

Updated issue summary.

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue summary:View changes

Updated issue summary.