This is only a cosmetic issue. On | Off buttons does not change state with jquery_update module active.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

SirClickalot’s picture

I can confirm that this is exactly the case, switching off jQuery restores the animation of the ON/OFF buttons.

MrPaulDriver’s picture

Yes confirm also

manhalt’s picture

I loaded a new Drupal 7.1.5 site with the 7.x-2.x-dev Module Filter module. Activating the jQuery Update module caused the same issue with the On | Off buttons for me as well.

littlekoala’s picture

I have the same issue

changed

$(':checkbox', $cell).change(function() {
  if (!$switch.hasClass('disabled')) {
    $switch.toggleClass('off');
  }
});

into

$(':checkbox', $cell).click(function() {
  if (!$switch.hasClass('disabled')) {
    $switch.toggleClass('off');
  }
});

in module_filter_tab.js resolved my problem.

sibiru’s picture

Hi thanks for creating this module, it help alot when building site with many module
I have same problem when enabling jquery update module 7.x-2.2

clicking "on/of button" the animation of the button not running

but when clicking "module name" to enabling the animation on/of is working, the color indicator of row when enabling/disabling module is working too.
I think it is not necessary the "module name" is clickable, just use on/off button to enabling/disabling module

FreeFox’s picture

I can confirm this too. I had installed a site yesterday with previous module_filter-dev version and it was all ok but with today's dev version (2012-11-27) the problem is as described above.

greenSkin’s picture

greenSkin’s picture

Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

willvincent’s picture

Issue summary: View changes
Status: Closed (fixed) » Needs review
FileSize
1.16 KB

This is still an issue even with the previous commit change.

The attached patch resolves it for me

jerry’s picture

My experience is the same as willvincent's. His patch in #10 fixes the problem for me as well, present when jQuery Update applies V1.5 or later for admin pages (which is now necessary for Media V2).

AlfTheCat’s picture

Confirming #10 works like a charm. Thanks so much!

jerry’s picture

Status: Needs review » Reviewed & tested by the community

Sounds ready for RTBC, then.

  • willvincent authored 88aaf31 on 7.x-2.x
    Issue #1710230 by willvincent: On | Off buttons does not change state...
greenSkin’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.