See #1711070: Convert tests to use ::$modules property instead of parent::setUp($modules).

CommentFileSizeAuthor
#8 help-1711350-8.patch3.35 KBtim.plunkett
#7 help-1711350-7.patch3.21 KBtim.plunkett
#1 drupal-1711350-1.patch1.57 KBkid_icarus
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

kid_icarus’s picture

kid_icarus CreditAttribution: kid_icarus commented
Assigned: Unassigned » kid_icarus
Status: Active » Needs review
FileSize
drupal-1711350-1.patch1.57 KB
tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Needs review » Reviewed & tested by the community

2/2

Status: Reviewed & tested by the community » Needs work

The last submitted patch, drupal-1711350-1.patch, failed testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented

Oh looks like it tries to set/use it's own version of $this->modules.

kid_icarus’s picture

kid_icarus CreditAttribution: kid_icarus commented
Status: Needs work » Needs review
Issue tags: -Novice, -Testing system

#1: drupal-1711350-1.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +Novice, +Testing system

The last submitted patch, drupal-1711350-1.patch, failed testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Needs work » Needs review
FileSize
help-1711350-7.patch3.21 KB

HelpTest::getModuleList() was documented as returning an array, but was using a property instead, which clashed with this new property.
So, I changed the method to do what it claims to do.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
FileSize
help-1711350-8.patch3.35 KB

Forgot to fix up NoHelpTest for the docs changed.

kid_icarus’s picture

kid_icarus CreditAttribution: kid_icarus commented
Status: Needs review » Reviewed & tested by the community

Looks good to me. Using help's own getModuleList method seems sensible, and the corresponding changes inside getModuleList seem correct.

Dries’s picture

Dries CreditAttribution: Dries commented

By the way, it wouldn't hurt to re-roll all these issues into one patch. It's not very convenient to have 30 small patches. Any takers to do that? It would be tremendously helpful.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Reviewed & tested by the community » Closed (duplicate)