See #1711070: Convert tests to use ::$modules property instead of parent::setUp($modules).

CommentFileSizeAuthor
#10 locale-1711394-10.patch12.23 KBno_commit_credit
#10 interdiff.txt712 bytesno_commit_credit
#9 locale-1711394-aggregator_test_modules_property-9.patch12.22 KBCameron Tod
#6 locale-1711394-aggregator_test_modules_property-5.patch12.26 KBCameron Tod
#4 locale-1711394-aggregator_test_modules_property-4.patch12.26 KBCameron Tod
#2 locale-convert_tests_to_use_modules_property-1711394.patch12.09 KBCameron Tod
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Cameron Tod’s picture

Cameron Tod CreditAttribution: Cameron Tod commented
Assigned: Unassigned » Cameron Tod
Cameron Tod’s picture

Cameron Tod CreditAttribution: Cameron Tod commented
Status: Active » Needs review
FileSize
locale-convert_tests_to_use_modules_property-1711394.patch12.09 KB

Sending for testing.

Status: Needs review » Needs work

The last submitted patch, locale-convert_tests_to_use_modules_property-1711394.patch, failed testing.

Cameron Tod’s picture

Cameron Tod CreditAttribution: Cameron Tod commented
Status: Needs work » Needs review
FileSize
locale-1711394-aggregator_test_modules_property-4.patch12.26 KB

Woops, missed calls to parent::setUp().

Status: Needs review » Needs work

The last submitted patch, locale-1711394-aggregator_test_modules_property-4.patch, failed testing.

Cameron Tod’s picture

Cameron Tod CreditAttribution: Cameron Tod commented
FileSize
locale-1711394-aggregator_test_modules_property-5.patch12.26 KB

Woops again

Cameron Tod’s picture

Cameron Tod CreditAttribution: Cameron Tod commented
Status: Needs work » Needs review
droplet’s picture

droplet CreditAttribution: droplet commented
Status: Needs review » Needs work

code standard: space problem

Cameron Tod’s picture

Cameron Tod CreditAttribution: Cameron Tod commented
Status: Needs work » Needs review
FileSize
locale-1711394-aggregator_test_modules_property-9.patch12.22 KB

Again

no_commit_credit’s picture

no_commit_credit CreditAttribution: no_commit_credit commented
FileSize
interdiff.txt712 bytes
locale-1711394-10.patch12.23 KB

Minor grammar fix. As in the name... no commit credit, please. :)

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented

And, the patch looks good. The docblock for LocaleCommentLanguageTest was converted correctly; I just added an article. Confirmed there are no remaining setUp() methods with arguments in the module once this patch is applied.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
Status: Needs review » Reviewed & tested by the community

Ahem. :)

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Reviewed & tested by the community » Closed (duplicate)