See #1711070: Convert tests to use ::$modules property instead of parent::setUp($modules).

CommentFileSizeAuthor
#5 path-1711400-5.patch4.93 KBkid_icarus
#5 interdiff.txt951 byteskid_icarus
#2 path-1711400-2.patch3.86 KBkid_icarus
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ZenDoodles’s picture

ZenDoodles CreditAttribution: ZenDoodles commented
Assigned: Unassigned » ZenDoodles
kid_icarus’s picture

kid_icarus CreditAttribution: kid_icarus commented
Assigned: ZenDoodles » kid_icarus
Status: Active » Needs review
FileSize
path-1711400-2.patch3.86 KB

Status: Needs review » Needs work

The last submitted patch, path-1711400-2.patch, failed testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented

The patch is missing at least PathLanguageUiTest, didn't check for others.

kid_icarus’s picture

kid_icarus CreditAttribution: kid_icarus commented
Status: Needs work » Needs review
FileSize
interdiff.txt951 bytes
path-1711400-5.patch4.93 KB

Whoops!

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Needs review » Reviewed & tested by the community

Looks good!

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Reviewed & tested by the community » Closed (duplicate)