There are two db_query function calls in videojs where the query string is delimited by ' characters, and the strings inside the query are delimited by " characters. This causes problems with PostgreSQL, where delimiting a string with " characters causes it to be interpreted as a column name. Better practice is to delimit SQL query strings with ", and delimit strings inside the query with '. Patch to follow.

Files: 
CommentFileSizeAuthor
#1 videojs-Fix_SQL_quoting_for_PostgreSQL-1712398-1.patch1.4 KBBen Coleman
PASSED: [[SimpleTest]]: [MySQL] 0 pass(es).
[ View ]

Comments

Status:Active» Needs review
StatusFileSize
new1.4 KB
PASSED: [[SimpleTest]]: [MySQL] 0 pass(es).
[ View ]

The attached patch fixes the above problem.

Thanks for the patch, I'll commit it asap.

Status:Needs review» Fixed

Thanks for your patch, it has been committed.

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.