Files: 
CommentFileSizeAuthor
#29 test-keep-results-1719530-28.patch2.69 KBalberto56
PASSED: [[SimpleTest]]: [MySQL] 40,533 pass(es).
[ View ]
#26 test-keep-results-1719530-26.patch2.67 KBdcam
PASSED: [[SimpleTest]]: [MySQL] 39,555 pass(es).
[ View ]
#24 test-keep-results-1719530-24.patch2.68 KBdcam
FAILED: [[SimpleTest]]: [MySQL] Failed to run tests: tests were executed, but no results were found.
[ View ]
#15 test.keep-results.15.patch1.02 KBsun
PASSED: [[SimpleTest]]: [MySQL] 41,080 pass(es).
[ View ]
#9 drupal8.run-tests-keep-results.9.patch952 bytessun
PASSED: [[SimpleTest]]: [MySQL] 39,988 pass(es).
[ View ]
#1 drupal-1719530-1.patch2.42 KBtim.plunkett
PASSED: [[SimpleTest]]: [MySQL] 39,892 pass(es).
[ View ]

Comments

Status:Active» Needs review
StatusFileSize
new2.42 KB
PASSED: [[SimpleTest]]: [MySQL] 39,892 pass(es).
[ View ]

See attached

Yea, as I suggested committing this first will make it easier to be sure the pifr change works before we commit the actual core change so we don't end up with the disruption we had yesterday with the commit.

I can't RTBC my own patch.

Status:Needs review» Reviewed & tested by the community

I can do that. (I should have mentioned above, I didn't write a single line of this, sun did).

It would be nicer if the command line settings where consistent with the settings in the Simpletest configuration UI.

I prefer --keep-results over --clear-results so maybe we should consider renaming the internal variable to simpletest_clear_results to simpletest_keep_results and updating the configuration UI accordingly? It would also make the code a tiny bit cleaner.

Status:Reviewed & tested by the community» Fixed

I don't want to hold up this issue on #5 so I decided to go ahead and commit it.

If people feel #5 is valuable, maybe we can create a follow-up patch or a new issue? Marking this issue 'fixed' for the time being.

The default, in both cases, should actually be to delete the results. Keeping the assertion results should be the opt-in, not the other way around.

So I'd be fine with patching the Simpletest module to rename its variable/config-key from clear_results to keep_results (as well as adjusting the UI and negating the default value).

Version:8.x-dev» 7.x-dev
Status:Fixed» Patch (to be ported)
Issue tags:+needs backport to D7

We actually need to backport this to D7...

Version:7.x-dev» 8.x-dev
Status:Patch (to be ported)» Needs review
StatusFileSize
new952 bytes
PASSED: [[SimpleTest]]: [MySQL] 39,988 pass(es).
[ View ]

Oh dear. I'm sorry.

was just going to post that I confirmed it was this from the other issue. testing.

Status:Needs review» Reviewed & tested by the community

Confirmed locally.

Version:8.x-dev» 7.x-dev
Status:Reviewed & tested by the community» Fixed

Oops. :)

Committed and pushed to 8.x. Thanks!

Moving back to 7.x.

Status:Fixed» Patch (to be ported)

Ahem.

Issue tags:+Testing system

Version:7.x-dev» 8.x-dev
Status:Patch (to be ported)» Reviewed & tested by the community
StatusFileSize
new1.02 KB
PASSED: [[SimpleTest]]: [MySQL] 41,080 pass(es).
[ View ]

Finally discovered why we're getting lots of verbose output in test results -- which lead to many more total test result assertions, and since PIFR has a maximum limit of assertions it displays, this means that actual errors and exceptions of failing tests are not displayed. (example)

This is a stop-gap fix for D8, which can be removed with #1705748: Convert simpletest settings to configuration system

Status:Reviewed & tested by the community» Fixed

Heh, oops. Since SimpleTest hasn't been converted to CMI yet, these settings currently have no effect. The temporary patch adds them back in under their old D7 names as a stop-gap.

Committed and pushed to 8.x.

Version:8.x-dev» 7.x-dev
Status:Fixed» Patch (to be ported)

Thanks! :)

For future reference note that this issue also change the definition of --verbose to include controlling the simpletest_verbose variable which controls the capturing the browser requests in DWTC.

To be fixed in one way or another in
#1774002: Correct mistake introduced in simpletest cmi conversion by introducing --verbose-browser flag

Priority:Major» Normal

Correct me if I'm wrong, but I don't believe this backport is actually major for 7.x; it merely keeps the code bases closer together. Tentatively de-prioritizing so that I can commit me some features. :)

Which of these patches should be backported? I ask because #15 is a "stop-gap fix for D8."

Version:7.x-dev» 8.x-dev
Status:Patch (to be ported)» Postponed (maintainer needs more info)

Actually, that is a fine question.

Version:8.x-dev» 7.x-dev
Status:Postponed (maintainer needs more info)» Patch (to be ported)

There are three patches in this issue that have been committed, and the cumulative result of all three of them should be backported.

Status:Patch (to be ported)» Needs review
StatusFileSize
new2.68 KB
FAILED: [[SimpleTest]]: [MySQL] Failed to run tests: tests were executed, but no results were found.
[ View ]

Backported #1, #9, and #15 to D7.

Status:Needs review» Needs work

The last submitted patch, test-keep-results-1719530-24.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new2.67 KB
PASSED: [[SimpleTest]]: [MySQL] 39,555 pass(es).
[ View ]

Fixed the filepath in line 410 of run-tests.sh that was causing the error in #24.

It would seem prudent to get #1774002: Correct mistake introduced in simpletest cmi conversion by introducing --verbose-browser flag in and add to backport since the patch as it stands introduces an "api change" by changing the meaning of --verbose instead of just two additional flags (only adds one the way it stands and alters meaning of the other).

StatusFileSize
new2.69 KB
PASSED: [[SimpleTest]]: [MySQL] 40,533 pass(es).
[ View ]

Here is a version of #26 which applies to 7.22.