The 'superfish' module also uses a 'superfish' library. This causes Drush generate make to overwrite the module's entry in $projects with the information about the library, resulting in an incomplete makefile.

This patch corrects the problem by separating the libraries from the projects.

CommentFileSizeAuthor
#2 generate-make-libraries-2.patch2.79 KBgreg.1.anderson
generate-make-libraries.patch1.81 KBgreg.1.anderson
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

greg.1.anderson’s picture

greg.1.anderson CreditAttribution: greg.1.anderson commented
Assigned: Unassigned » greg.1.anderson
Status: Needs review » Needs work

The patch above includes the header twice. :p

greg.1.anderson’s picture

greg.1.anderson CreditAttribution: greg.1.anderson commented
Status: Needs work » Needs review
FileSize
generate-make-libraries-2.patch2.79 KB

Here is an updated version that passes the test suite.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom commented
Status: Needs review » Reviewed & tested by the community

Patch looks reasonable to me--I haven't run the tests, or tested manually, but if the suite is passing, feel free to commit.

greg.1.anderson’s picture

greg.1.anderson CreditAttribution: greg.1.anderson commented
Status: Reviewed & tested by the community » Fixed

Committed; thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.