Empty parser results fails import.
Splitting #1428272: Added support of encoding conversions to the CSV Parser into separate patches, part 1.
Patch is on the way...

CommentFileSizeAuthor
#1 0001-Issue-1720658-by-OnkelTem-Empty-parser-s-results-fai.patch1.08 KBOnkelTem
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

OnkelTem’s picture

OnkelTem CreditAttribution: OnkelTem commented
Status: Active » Needs review
FileSize
0001-Issue-1720658-by-OnkelTem-Empty-parser-s-results-fai.patch1.08 KB
twistor’s picture

twistor CreditAttribution: twistor commented
Status: Needs review » Closed (works as designed)

Sorry for the delay.
So this happens when the parser fails. With this patch, it would still fail, but it would fail silently. I'm opposed to this. When things fail, I want them to fail as loudly as possible. Otherwise, I will just get bug reports saying, "Import doesn't work." At least now, I know that it was the parser that failed.

If I am completely off here, let me know.

OnkelTem’s picture

OnkelTem CreditAttribution: OnkelTem commented

Not a problem, we can simply consider some example (failing) csv file and decide how to process it correctly.