Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Issue to track necessary changes once #1227706: Add a file entity access API goes in.
also relevant
media_browser_plus - #1410500: wrong permissions are used (in media?)
media - #1677054: Use file_entity_access() instead of media_access()
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | 1721524-1-file_access.patch | 4.3 KB | Jackinloadup |
Comments
Comment #1
Jackinloadup CreditAttribution: Jackinloadup commentedComment #2
mrfelton CreditAttribution: mrfelton commentedI think this is a duplicate of #1410500: wrong permissions are used (in media?) which has already been committed. This patch certainly doesn't apply any more.
Comment #3
Jackinloadup CreditAttribution: Jackinloadup commentedThis patch is not a duplicate of #1410500: wrong permissions are used (in media?) but does most likely need to be rerolled.
This patch converts the permission system to use the new file_access functionality that is soon to be in the file_entity module per #1227706: Add a file entity access API.
#1227706: Add a file entity access API will help consolidate the permissions through Media and other modules like Media Browser plus though not all permissions in this module will go away as file_access understandably wont cover them all.
I'm not sure how many permissions should be consolidated to file_access but many of them seem relevant. Please review.
TODO:
For now im going to mark this issue as postponed until #1227706: Add a file entity access API gets in. Then we can move forward with this.
Comment #4
Jackinloadup CreditAttribution: Jackinloadup commentedFile entity patch is now in. This patch can move forward.
Comment #5
salvis