I had posted this in #1549660: Allow Styling of Regions in the Panels IPE, but I think it got lost in the excitement. Basically there seems to be problems with some style plugins (namely the ones that organize the panes into a list like the "List" plugin provided by Panels) where the $panes['empty_placeholder'] markup is accidentally added to the themed list of content.

This problem can be seen in this screenshot (http://drupal.org/files/panels-list-region-style-ipe.png) and fixed with the attached patch (http://drupal.org/files/1549660-list-region-style-dont-render-empty-plac...) as per this screenshot (http://drupal.org/files/panels-list-style-ipe-patch-applied.png).

I am going to presume there is a more global way to exclude that pane from the region theme functions, but this patch will help to explain the problem.

CommentFileSizeAuthor
#4 1728776-render-ipe-region-control-outside-of-region-style.patch2.64 KBmerlinofchaos
#2 1728776-empty-placeholder-at-end-of-output.patch1.54 KBpopulist
list-region-style-dont-render-empty-placeholder.patch824 bytespopulist
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

merlinofchaos’s picture

merlinofchaos CreditAttribution: merlinofchaos commented
Status: Active » Needs review

Ok, I'm backpedaling on this not being fixable. Let's try this.

populist’s picture

populist CreditAttribution: populist commented
FileSize
1728776-empty-placeholder-at-end-of-output.patch1.54 KB

It might be worth considering a more general solution (see http://drupal.org/files/1728776-empty-placeholder-at-end-of-output.patch) which works fine for the rendering of the regions on the display.

There is a problem (which happens with or without the patch) when you try to add new panes into region style (i.e. accordian or list) that looks like this: PDOException: SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry '16' for key 'PRIMARY':. I presume that is due to the numbering, but if there is a fix possible for that then the attached patch should work.

merlinofchaos’s picture

merlinofchaos CreditAttribution: merlinofchaos commented

Argh. A second time a patch I tried to attach did not actually attach. Grr.

merlinofchaos’s picture

merlinofchaos CreditAttribution: merlinofchaos commented
FileSize
1728776-render-ipe-region-control-outside-of-region-style.patch2.64 KB
merlinofchaos’s picture

merlinofchaos CreditAttribution: merlinofchaos commented

There, finally!

merlinofchaos’s picture

merlinofchaos CreditAttribution: merlinofchaos commented
Status: Needs review » Fixed

I went ahead and committed #4; it's fundamentally similar to #2, except I let the HTML actually be put in the theme function for slightly more flexibility for things that want to change the look of the IPE more.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 2574841 on 7.x-3.x, 7.x-3.x-i18n, 8.x-3.x by merlinofchaos: 
    Issue #1728776: Render IPE region controls outside of region style.