It doesn't make sense to have a button that says "No" when Drupal will set cookies regardless. I suggest taking the "No" out of the button text and shortening it to "Find out More".

Comments

Miszel’s picture

Miszel CreditAttribution: Miszel commented
Status: Active » Closed (works as designed)

There are two ways of changing the text to whatever you require it to be.

1) Use the translation interface to 'translate' the string to whatever you need.
2) Override the tpl.php file.

tkoterwas’s picture

tkoterwas CreditAttribution: tkoterwas commented

Yes I know I can do that, but I'm pointing out a fundamental issue with the default implementation that in my opinion should be addressed. It makes no sense and is very confusing to provide a "No" button if it doesn't actually prevent cookies from being set. We maintain a lot of sites, and overriding for each is a lot of effort for something that should be the default. Please reconsider this request as it would be a huge UI improvement.

Thanks very much for the module. It has already saved us a good deal of effort.

BioALIEN’s picture

BioALIEN CreditAttribution: BioALIEN commented

I agree with tkoterwas above, "Read more" or "Find out more" is the more appropriate string to use here as disagreeing and clicking the button doesn't actually prevent cookies from being set and this is misleading to say the least.

achton’s picture

achton
Location Denmark
CreditAttribution: achton commented
Version: 6.x-1.7 » 6.x-1.x-dev
Status: Closed (works as designed) » Fixed

I agree with the sentiment here, and have updated the string in the templates for 6.x and 7.x.

6.x commit: deb7032
7.x commit: 75e84f2

achton’s picture

achton
Location Denmark
CreditAttribution: achton commented
Status: Fixed » Postponed

Having discussed this further with Marcin, I have reverted that change from the current -dev versions of 6.x and 7.x. It will break translations for all non-english sites using the module, if we do this in a minor release cycle.

Instead we can choose to do this in a 2.x-branch or make sure the existing translations are supported. I have not been able to find precedent for such a thing (I asked in #drupal-i18n) and this apparently not usually done.

In any case, this issue is postponed for now.

svenryen’s picture

svenryen CreditAttribution: svenryen commented
Issue summary: View changes

This has been fixed in the 7.x branch. Would anybody be interested in porting that fix to d6?

  • Commit 75e84f2 on 7.x-1.x, 8.x-1.x, 7.x-2.x by achton: 
    Issue #1732636: Changed "No, I want to find out more" to "Find out more...
  • Commit 75b36a4 on 7.x-1.x, 8.x-1.x, 7.x-2.x by achton:
    Revert commit 75e84f2: Issue #1732636.
svenryen’s picture

svenryen CreditAttribution: svenryen commented
Status: Postponed » Closed (fixed)