Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.If you choose the Basic Button display, the button image will always use HTTP, which can lead to problems when using HTTPS/SSL.
Attached patch makes use of the AddThis::validateSecureUrl() method introduced in http://drupal.org/node/1403210, and changes validateSecureUrl() to a public method.
If you want to keep validateSecureUrl() private I think you'd need to refactor and hold the logic for big button/small button URLs in a public method in the AddThis class.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 1734752-https-button-img-3.txt | 2.01 KB | matglas86 |
Comments
Comment #1
matglas86 CreditAttribution: matglas86 commentedI would like to do a little refactoring here. Changing the name of the method and creating a public method then. At this point its stille posible without breaking the api
Comment #2
matglas86 CreditAttribution: matglas86 commentedI changed the methods a little bit. I prefere the seperation of this functionality because we can reuse it better. Feedback welcome.
Comment #3
matglas86 CreditAttribution: matglas86 commentedMerging in this change to fix this.