flag_flag_definitions() needs a module_exists().

Files: 
CommentFileSizeAuthor
#15 1736486.15.flag_conditional_comment6x2x.patch1.01 KBsocketwench
PASSED: [[SimpleTest]]: [MySQL] 61 pass(es).
[ View ]
#14 1736486.14.flag_conditional_comment7x2x.patch887 bytessocketwench
PASSED: [[SimpleTest]]: [MySQL] 61 pass(es).
[ View ]
#11 1736486.11.flag_conditional_comment_7x2x.patch896 bytessocketwench
FAILED: [[SimpleTest]]: [MySQL] Invalid patch format in 1736486.11.flag_conditional_comment.patch.
[ View ]
#6 1736486.6.flag_.conditional-comment-type.patch903 bytesjoachim
PASSED: [[SimpleTest]]: [MySQL] 65 pass(es).
[ View ]
#2 1736486.flag_.conditional-comment-module.patch1 KBjoachim
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1736486.flag_.conditional-comment-module.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Comments

Tagging.

Status:Active» Needs review
StatusFileSize
new1 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1736486.flag_.conditional-comment-module.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Let's see if this patch I wrote on 6 works on 7!!!!

Status:Needs review» Needs work

The last submitted patch, 1736486.flag_.conditional-comment-module.patch, failed testing.

Version:7.x-2.x-dev» 7.x-3.x-dev
Status:Needs work» Postponed

I'm an idiot -- this needs fixing on 7--3 too.

Postponing until the hook changes are decided on.

Status:Postponed» Active

Hook changes made; this can now be looked at.

Status:Active» Needs review
StatusFileSize
new903 bytes
PASSED: [[SimpleTest]]: [MySQL] 65 pass(es).
[ View ]

Status:Needs review» Needs work

The last submitted patch, 1736486.6.flag_.conditional-comment-type.patch, failed testing.

Status:Needs work» Reviewed & tested by the community

Looks good to me. Tests clean.

Status:Reviewed & tested by the community» Fixed

Thanks for the review!

Issue #1736486 by joachim: Fixed comment flags are defined when comment module is absent.

Version:7.x-3.x-dev» 7.x-2.x-dev
Status:Fixed» Patch (to be ported)

Needs porting to 7-2.

StatusFileSize
new896 bytes
FAILED: [[SimpleTest]]: [MySQL] Invalid patch format in 1736486.11.flag_conditional_comment.patch.
[ View ]

Backport to 7.x-2.x.

Status:Patch (to be ported)» Needs review

Status:Needs review» Needs work

The last submitted patch, 1736486.11.flag_conditional_comment.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new887 bytes
PASSED: [[SimpleTest]]: [MySQL] 61 pass(es).
[ View ]

Version:7.x-2.x-dev» 6.x-2.x-dev
StatusFileSize
new1.01 KB
PASSED: [[SimpleTest]]: [MySQL] 61 pass(es).
[ View ]

D6 backport.

Status:Needs review» Fixed

Committed. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.