Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Onwards from http://drupal.org/node/1189184#comment-6285584,
- @sun noted that try/catch statements should not be on the same line
- @attiks noted a debug line left around
- @webchick noted $exc should be renamed to $exception
The first two are already fixed, the last one still needs to be fixed.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | code_style-1737186-3.patch | 1.29 KB | sxnc |
| locale-catch-259.patch | 1.28 KB | Gábor Hojtsy | |
Comments
Comment #1
Gábor HojtsySend to testbot at first anyway, should be set back to needs work after unless a fixed patch is provided :)
Comment #2
Gábor HojtsyThe variable is still to be renamed.
Comment #3
sxnc CreditAttribution: sxnc commentedFixing issue #3
Comment #4
Gábor HojtsyOk, looks like the exception data is not used in fact, since we already know the file and can report the error. If this comes back green, it should be RTBC then.
Comment #5
Gábor HojtsyShould be good to go!
Comment #6
webchickCommitted and pushed to 8.x. Thanks!
Comment #7
Gábor HojtsyOff of the sprint then. Thanks!
Comment #8
Gábor HojtsyPutting back on sprint just for easier tracking of our work. Will remove later next week.
Comment #9
Gábor HojtsyRemoving as promised. We do not need a change notice or changelog entry for this.