Typekit fonts can't be updated - API change? [#1741004]

Since last week I get the following errors when trying to update the typekit fonts:

Notice: Undefined property: stdClass::$foundry in typekit_api_fontyourface_import() (line 69 of /home/patrickd/www/drupal7/sites/default/modules/fontyourface/modules/typekit_api/typekit_api.module).
Notice: Trying to get property of non-object in typekit_api_fontyourface_import() (line 69 of /home/patrickd/www/drupal7/sites/default/modules/fontyourface/modules/typekit_api/typekit_api.module).

This seems to me like typekit changed their api and told nobody..

Quick fix:
Changing in the fontyourface_font table:
Column: css_selector, Value: NULL, Change to <none>

Comment	File	Size	Author
#2	typekit_api_change-1741004-2.patch	1.79 KB	patrickd
#2
#1	typekit_api_change-1741004-1.patch	2.19 KB	patrickd
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

patrickd CreditAttribution: patrickd commented 20 August 2012 at 13:04

Version:	7.x-2.4	» 7.x-2.x-dev
Status:	Active	» Needs review

File	Size
typekit_api_change-1741004-1.patch	2.19 KB

following patch resolves this issue for me

- checks whether there's a foundry property in the returned data
- makes sure that <none> is set as css selector by default

Comment #2

patrickd CreditAttribution: patrickd commented 20 August 2012 at 13:09

File	Size
typekit_api_change-1741004-2.patch	1.79 KB

Oops, removed some documentation.

rerolled against current 7.x-2.x

Comment #3

Drave Robber CreditAttribution: Drave Robber commented 20 August 2012 at 14:40

Typekit has indeed made some changes: http://blog.typekit.com/2012/08/16/performance-improvements-to-font-serv...
They're saying "You don’t need to do anything" ~~but I'm not so sure~~ and well, they may be right after all.

~~For me, Typekit silently fails to import anything at the moment.~~ (this was due to recent changes in my local setup, so totally unrelated)

I successfully updated my two fonts in a trial library; could it be that this is related to some specific font that's missing foundry name?

Comment #4

sreynen CreditAttribution: sreynen commented 8 November 2012 at 05:27

Status:

Needs review

» Needs work

This patch appears to have two changes: 1) adding a conditional check around setting the foundry info, and 2) Changing NULL to <none>. #1 seems good to me. I don't understand why #2 is there. Changing the selector from NULL to <none> means the fonts get loaded, but they're still not applied by the module. Are you applying Typekit fonts some other way? In any case, #2 seems like it should be a separate issue, unless I'm just completely missing the connection to #1.

Comment #5

patrickd CreditAttribution: patrickd commented 8 November 2012 at 11:17

As far I could see the service returned <none> at first, but now returns NULL instead. #2 just fixes this change

I have pretty much no idea why the api changed this way, I also could not find any documentation about the change itself.
I just encountered the issue and this patch seemed to be the only way to get it working again.

As far I can see #1, as well as #2 are necessary to make the module work with typekit correctly again, therefore I'd keep them in this issue.