Spin-off from #1510532: [META] Implement the new create content page design - a more modern CSS reset for Seven theme. Please refer to original issue for reasoning.

Files: 
CommentFileSizeAuthor
#3 1747868-3-new-reset.patch10.83 KBmrfelton
PASSED: [[SimpleTest]]: [MySQL] 40,549 pass(es).
[ View ]
#1 1747868-1-new-reset.patch10.23 KBkika
PASSED: [[SimpleTest]]: [MySQL] 40,410 pass(es).
[ View ]

Comments

StatusFileSize
new10.23 KB
PASSED: [[SimpleTest]]: [MySQL] 40,410 pass(es).
[ View ]

And here's the patch.

I totally agree with this. But, isn't a reset.css supposed to come first in order of loaded css files? What we are getting at the moment is like this:

<link rel="shortcut icon" href="http://d8.local/core/misc/favicon.ico" type="image/vnd.microsoft.icon" />
    <title>Create Article | d8.local</title>
    <style media="all">
@import url("http://d8.local/core/modules/system/system.base.css?m99s9z");
@import url("http://d8.local/core/modules/system/system.theme.css?m99s9z");
</style>
<style media="all">
@import url("http://d8.local/core/modules/system/system.admin.css?m99s9z");
@import url("http://d8.local/core/themes/seven/vertical-tabs.css?m99s9z");
</style>
<style media="all">
@import url("http://d8.local/core/modules/comment/comment.theme.css?m99s9z");
@import url("http://d8.local/core/modules/field/theme/field.css?m99s9z");
@import url("http://d8.local/core/modules/user/user.css?m99s9z");
</style>
<style media="all">
@import url("http://d8.local/core/modules/filter/filter.admin.css?m99s9z");
@import url("http://d8.local/core/modules/file/file.admin.css?m99s9z");
@import url("http://d8.local/core/modules/image/image.theme.css?m99s9z");
@import url("http://d8.local/core/modules/toolbar/toolbar.css?m99s9z");
@import url("http://d8.local/core/modules/shortcut/shortcut.base.css?m99s9z");
@import url("http://d8.local/core/modules/shortcut/shortcut.theme.css?m99s9z");
</style>
<style media="screen">
@import url("http://d8.local/core/themes/seven/reset.css?m99s9z");
@import url("http://d8.local/core/themes/seven/style.css?m99s9z");
</style>

So the reset stuff is happening after a bunch of module level css styles. Wonder if we can/should force it to load first?

StatusFileSize
new10.83 KB
PASSED: [[SimpleTest]]: [MySQL] 40,549 pass(es).
[ View ]

Updated patch to ensure that reset.css is the first stylesheet loaded.

Issue tags:+html5, +css cleanup

In order to get this in, it needs reviews from CSS team and good issue summary. Could someone go back to #1510532: [META] Implement the new create content page design and figure out at what point new reset was introduced and why that was important? There should be more reasoning than just "new reset.css is more modern"?

I did some research in the issue queue and found #723392: Tame seven's reset.css: tame Seven's reset. I agree with the assessment that Seven's existing reset is overkill, but either way I wanted some resolution there before making theme changes for #1510532: [META] Implement the new create content page design . Consensus was that normalize.css would be considered a good replacement, so I posted that patch there and built the Creat Content patch on top. It was introduced around #238 in #1510532: [META] Implement the new create content page design.

So, @ry5n's patch at #723392: Tame seven's reset.css is duplicate of the patch in this issue? If so, one of them should be marked as dupe.

Note: I edited last comment to be more readable.

One of my problem with the old css reset from Seven is that it includes stuff that resets styles added by Drupal's system modules. A reset stylesheet should come first, and should only need to reset browser styles.

So what to do with this issue? It's not super-hard requirement for #1751754: Implement new form style for Seven, based on blueprint mockups. but it will remove some of the artifacts in font sizing http://drupal.org/node/1510532#comment-6381930

Any CSS cleanup people to weight in and give an opinion whenever we need a modern reset.css in core?

Status:Needs review» Closed (duplicate)

This is really a duplicate of http://drupal.org/node/723392. In my haste I included an updated reset as part of the create content page patch, which got spun off here. I think we should move back over to the original issue. Just posted an updated version of the latest patch there plus updates from normalize 2.0.1 and screenshots for testing.