I have a user that complained that all of their entity changes weren't being saved (create new, add existing, edit, delete). Turned out he was clicking the inline "save" button, but not the main node "save" button at the bottom of the page.

Views says:

* All changes are stored temporarily. Click Save to make your changes permanent. Click Cancel to discard your changes.

We should say something similar!

CommentFileSizeAuthor
#6 1750964-6.patch847 byteskhiminrm
#5 edit_page.png25.88 KBarunkumark
#2 help_message_for_ief_saving_data.-1750964-2.patch889 bytesvasike
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented

My workaround for now is to add a Drupal style yellow warning message to the bottom of the IEF form:

/**
 * Implements hook_form_FORM_ID_alter()
 * 
 * Add warning to IEF that you need to click the main save button at the bottom of the page
 * otherwise all changes will be lost
 **/
function YOUR_MODULE_form_product_display_node_form_alter(&$form, &$form_state, $form_id) {
	$warn = '<div class="messages warning">* All changes are stored temporarily. Click Save at the bottom of the page to make your changes permanent.</div>';
	$element = &$form["field_product"]["und"]["actions"];
	// don't forget about any existing suffix
	$element["#suffix"] = (isset($element["#suffix"])) ? $warn.$element["#suffix"] : $warn;
}
vasike’s picture

vasike
Location Ramnicu Valcea
CreditAttribution: vasike commented
Status: Active » Needs review
FileSize
help_message_for_ief_saving_data.-1750964-2.patch889 bytes

i think this is helpful, patch attached.

i also think this should be accompanied by this one : #1891696-2: Rename the 'Save variation' button to 'Update variation'.

JvE’s picture

JvE CreditAttribution: JvE commented

I like it. My users are having the same issues.

But the classes do not work on themes that exclude system.messages.css (like bootstrap).
And the "Save" button may not be called "Save" so the message probably needs customizing.

NancyDru’s picture

NancyDru
she/her/hers
Primary language English
Location Boston
CreditAttribution: NancyDru commented
Issue summary: View changes

Actually, I am seeing that both Update/Save buttons must be clicked to make sure all the data is reliably saved.

arunkumark’s picture

arunkumark
Location Coimbatore
CreditAttribution: arunkumark as a volunteer and at DrupalPartners for CodeExpertz commented
Status: Needs review » Reviewed & tested by the community
FileSize
edit_page.png25.88 KB

The patch was working as expected. Attached screenshot for the reference.
Making the patch into RTBC

khiminrm’s picture

khiminrm CreditAttribution: khiminrm at Centarro commented
FileSize
1750964-6.patch847 bytes

Re-created the patch to latest dev.

geek-merlin’s picture

geek-merlin
they/omg
Primary language German
Location Freiburg, Germany
CreditAttribution: geek-merlin at Geeks4Change, MachbarMacher commented
Issue tags: +Port to D8+

  • ram4nd committed 11ca051 on 7.x-1.x 
    Issue #1750964 by khiminrm, vasike, arunkumark: Add views-style warning...
ram4nd’s picture

ram4nd CreditAttribution: ram4nd as a volunteer commented
Status: Reviewed & tested by the community » Fixed
dww’s picture

dww
we/he/they
CreditAttribution: dww at TEN7 commented
Status: Fixed » Patch (to be ported)

Thanks for this UX improvement.

Is there a D9+ version of this? Seems weird to be adding new features for D7 that don’t have parity in D9+. It’d become a regression for folks that rely on this in D7 when they try to upgrade.

ram4nd’s picture

ram4nd CreditAttribution: ram4nd as a volunteer commented

Isn't it in core in D8+?