t function is not defined error when importing wrongly formatted po file [#1751228]

When importing badly formatted po file error occurs:
Fatal error: Function name must be a string in core/lib/Drupal/Component/Gettext/PoStreamReader.php on line 518
Problem is that code

// Initialize common values for error logging.
    $log_vars = array(
        '%uri' => $this->getURI(),
        '%line' => $this->_line_number,
    );
    $t = get_t();

is inside if(), but error reporting with $t is outside it

I'm attaching po file with which error happens and patch

Comment	File	Size	Author
#2	t_not_defined_on_import_1751228_2.patch	1.5 KB	MantasK
#2
	lt.po	1.38 KB	MantasK
	t_not_defined_on_import.patch	1.24 KB	MantasK

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

24 August 2012 at 15:09

Status:

Needs review

» Needs work

The last submitted patch, t_not_defined_on_import.patch, failed testing.

Comment #2

MantasK CreditAttribution: MantasK commented 26 August 2012 at 14:48

File	Size
t_not_defined_on_import_1751228_2.patch	1.5 KB

one more try. fixed white spaces, maybe thats why patch was not accepted.

Comment #3

MantasK CreditAttribution: MantasK commented 26 August 2012 at 14:48

Status:

Needs work

» Needs review

Comment #3.0

MantasK CreditAttribution: MantasK commented 26 August 2012 at 14:48

Issue summary:

View changes

description change

Comment #4

clemens.tolboom

Dutch

Groningen, 🇳🇱/🇪🇺

CreditAttribution: clemens.tolboom commented 10 April 2014 at 13:03

Issue summary:	View changes
Status:	Needs review	» Needs work

Do you have an example of a bad PO file? Can you please check your findings against latest core what happens?

It is only necessary to place $t = get_t(); outside the if statement. You patch changes to many things. OTOH I guess this is not applicable anymore.

Please close the bug when not applicable anymore :)