Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Part of the JavaScript selectors clean-up effort.
#1574470: Selectors clean-up
#1415788: Javascript winter clean-up
Comment | File | Size | Author |
---|---|---|---|
#34 | interdiff_1751356_31-33.txt | 4.72 KB | karishmaamin |
#33 | 1751356-33.patch | 4.09 KB | karishmaamin |
#31 | 1751356-31.patch | 4.19 KB | srilakshmier |
Comments
Comment #1
nod_Arg tabledrag-y code :/
don't use the second parameter of once
the .each() should be named functions
use .on
reduce the function nesting.
Comment #2
nod_tag
Comment #3
Manuel Garcia CreditAttribution: Manuel Garcia commentedComment #4
pguillard CreditAttribution: pguillard commentedA first patch.
I made a turn on the field interface, it seems that nothing is broken...
Comment #5
pguillard CreditAttribution: pguillard commentedComment #7
pguillard CreditAttribution: pguillard commentedPatch rerolled
Comment #10
droplet CreditAttribution: droplet commentedThanks @pascalduez and @pguillard !!
However, since jQuery.Once 2.x, I think we don't need this refactoring
Comment #11
andriyun CreditAttribution: andriyun at Skilld, Drupal Ukraine Community commentedPatch #7 is ok for me.
Thank you @pguillard
+1 to RTBC
Comment #12
andriyun CreditAttribution: andriyun at Skilld, Drupal Ukraine Community commentedComment #13
andriyun CreditAttribution: andriyun at Skilld, Drupal Ukraine Community commentedComment #14
andriyun CreditAttribution: andriyun at Skilld, Drupal Ukraine Community commentedbot trigger
Comment #15
andriyun CreditAttribution: andriyun at Skilld, Drupal Ukraine Community commentedComment #16
andypostthis needs manual test while there's no js testing
Comment #21
kwoxer CreditAttribution: kwoxer commentedNeeds a re-roll since there has been changed lot's of things in that file.
Comment #22
andypostComment #23
droplet CreditAttribution: droplet commentedSince we have no confidence to commit a patch without testing. I postponed this until we have a better JS testing engine: #2869825: Leverage JS for JS testing (using nightwatch).
Comment #26
GaëlGThe dependency is now fixed, so I guess this needs work again.
Comment #27
kostyashupenkoComment #30
andypostComment #31
srilakshmier CreditAttribution: srilakshmier at Valuebound for Valuebound commentedRerolled the patch for 9.4.x. Please review.
Thank you
Comment #32
andypostComment #33
karishmaamin CreditAttribution: karishmaamin at Specbee commentedComment #34
karishmaamin CreditAttribution: karishmaamin at Specbee commentedinterdiff #31 and #33
Comment #35
DamienMcKennaFYI you are not supposed to modify the JS files directly, you are supposed to modify the .es6.js files and then compile them; see https://www.drupal.org/node/2815083 for details.
Removing the "needs reroll" tag as it is not relevant anymore.