This issue does not exist in the 4.x-dev version because the code has changed. So please don't reset the version to 4.x-dev with a port-back to v3 tag. This only exists in version 3. (currently)
By default Omega adds "border: 0;" to the "table" element. This makes it impossible for beginners to override the border in the WYSIWYG scenario. When using a WYSIWYG the border is added via border="1" and not through style="border: 1px". Therefore the default Omega border always overrides the user entered value.
I know that it's possible for someone to put style="border: 5px;" in the WYSIWYG and make it work. However, most of the clients I (and probably most people) build websites for don't have CSS knowledge.
So to keep this user friendly I suggest we remove the borders on tables as a default.
Comment | File | Size | Author |
---|---|---|---|
#1 | remove_table_borders-1751362-1.patch | 251 bytes | Steven Brown |
Comments
Comment #1
Steven Brown CreditAttribution: Steven Brown commentedHere's the patch to fix this.
Comment #2
Steven Brown CreditAttribution: Steven Brown commentedSorry I was in a bit of a hurry there.
Comment #3
Cellar Door CreditAttribution: Cellar Door commentedWe'll have to look at how this will effect the existing sites in production. Seems small enough not to matter but now that we've got so many sites small edits to the base css like this need to be done carefully. I'll talk w/ himerus to see if it can go into the 3.2 update.
Comment #4
Steven Brown CreditAttribution: Steven Brown commentedThank you for the reply. I couldn't agree with you more. We do need to be careful with this.
Comment #5
Steven Brown CreditAttribution: Steven Brown commentedChecking in on an update. Is this something we are willing to commit or just having to wait until the latest version?
Comment #6
Steven Brown CreditAttribution: Steven Brown commented#1: remove_table_borders-1751362-1.patch queued for re-testing.
Comment #7
Steven Brown CreditAttribution: Steven Brown commented#1: remove_table_borders-1751362-1.patch queued for re-testing.
Comment #8
Valeratal CreditAttribution: Valeratal commentedin alpha-reset.css
table, tbody, tfoot, thead, tr, th, td {
margin: 0;
padding: 0;
border: 0;
outline: 0;
font-size: 100%;
vertical-align: baseline;
font: inherit;
}
"border 0" need remove