I don't know how to create patches yet, but if anyone else need it, just edit function twitter_bootstrap_menu_navigation_links in includes/twitter_bootstrap.inc and start it with this code:

if (function_exists('i18n_menu_localize_tree')) {
$tree = i18n_menu_localize_tree($tree);
}

Hope it helps someone else.

CommentFileSizeAuthor
#10 i18n_menu_translation-1761934-10.patch879 byteswebnicola
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

wundo’s picture

Status: Patch (to be ported) » Needs work
andregriffin’s picture

Project: Twitter's Bootstrap » Bootstrap Framework
wundo’s picture

Project: Bootstrap Framework » Twitter's Bootstrap
natted’s picture

Project: Twitter's Bootstrap » Bootstrap
natted’s picture

Another similar issue was described here in #1678330: User menu does not select proper language items

I'll try to run some tests with the solution provided by RollWhisTler and see how things go.

sdfoui’s picture

suscribe

ydahi’s picture

Issue summary: View changes

Any update on this?

Can confirm that suggested update from RollWhisTler works (displays dropdown menu when language is selected).

Should this not be committed? (don't want to hack the bootstrap codebase unless absolutely necessary).

Thanks

markhalliwell’s picture

Version: 7.x-2.x-dev » 7.x-3.x-dev
Status: Needs work » Postponed (maintainer needs more info)

I am unfamiliar with this module, please provide a patch or at least a general idea of what needs to happen and where so this can be fixed in 7.x-3.x.

markhalliwell’s picture

Status: Postponed (maintainer needs more info) » Closed (outdated)

No response.

webnicola’s picture

Hi guys,
I created a patch with my solution to this problem.
In: /templates/system/page.vars.php

// Primary nav.
  $variables['primary_nav'] = FALSE;
  if ($variables['main_menu']) {
    // Load the tree
    $tree = menu_tree_all_data(variable_get('menu_main_links_source', 'main-menu'));
    // Localize the tree.
    if (module_exists('i18n_menu')) {
      $tree = i18n_menu_localize_tree($tree);
    }
    // Build links.
    $variables['primary_nav'] = menu_tree_output($tree);
    // Provide default theme wrapper function.
    $variables['primary_nav']['#theme_wrappers'] = array('menu_tree__primary');
  }
webnicola’s picture

Status: Closed (outdated) » Needs review

  • markcarver committed 135aa79 on 7.x-3.x authored by webnicola
    Issue #1761934 by webnicola, markcarver, RollWhisTler: Translate menu...
  • markcarver committed 85b0947 on 7.x-3.x
    Issue #1761934 by webnicola, markcarver, RollWhisTler: Translate menu...
markhalliwell’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

LynetteW’s picture

When I updated my Bootstrap theme to 7.x-3.16, which includes this patch, I noticed my non-expanded menu items in my main navigation were not working correctly either with or without the "Show as expanded" checkbox marked. Menu items that I did not want expanded, that had several children, were expanding (so they stay expanded no matter what option I chose). I went back to the Bootstrap release notes, looked over them and assumed this patch may have been breaking the menu.

From what this patch listed, I removed the lines of code added added back in the line that was removed, and the menu was fine. I feel like this is removing base Drupal functionality, can this please be reopened?

-LynetteW

hass’s picture

Another bug introduced by this case.