Saving a node with an empty menu link title causes the menu link to silently not be created

An updated patch for Drupal 8

Here another option.We are inside a form alter so we could add a little validation.I think is better than write something (title) automatically by default because maybe the user in this case has no reference whats going on exactly.

At localhost it works so I try again.

This needed a test. There was already a test case for a blank menu link title, so I added a couple of asserts to it. They check that we're redirected to the node edit page and the validation error message appears.

This was my first attempt at adding to a test, so constructive criticism is welcome.

#8: empty-menu-link-title-1763002-8.patch queued for re-testing.

#8: empty-menu-link-title-1763002-8-tests-only.patch queued for re-testing.

Rerolled #8.

On a fresh installation of Drupal 8.x-dev on March 8, 2013, I can confirm that the problem of no menu link is created - and no error message is printed either after following the steps in summary. See screenshot.
After applying the patch empty-menu-link-title-1763002-12.patch in #12 by dcam, I can confirm that the patch worked by the form not submitting but showing the proposed error messages nicely. See screenshot.

I agree with David_Rothstein falling back to the node title makes more sense than conditionally validating the menu title for the same reason the menu link is prefilled with the node title.

If a menu link is a required field, it should have the #required attribute. The problem with this approach is that the States API can not yet conditionally validate required fields.

I created a new patch based on the #2 proposed resolution.

Seems like adding a quick test or assertion to MenuNodeTest here would be worthwhile.

There's a first, fixed the assertion by removing lines :)

Rerolling patch #20.

Partial review (needs someone else to RTBC)

- Reproduced original problem (8.2.x)
- Patch fixes it
- No UI changes
- coding style fine
- All seems to be in scope
- Tests passed and test modified for functional change

The comment above the altered test was out of date, I've updated it.

Patch #29 can't be applied.Needs reroll.

Checking patch core/modules/menu_ui/menu_ui.module...
Hunk #1 succeeded at 335 (offset -36 lines).
Checking patch core/modules/menu_ui/src/Tests/MenuNodeTest.php...
error: core/modules/menu_ui/src/Tests/MenuNodeTest.php: No such file or directory

Rerolled patch #29 .Please check

@Abhijith S the patch seems not working for D9

Hi @Abhijith S,
Verified and tested patch #37.
Patch applied successfully and not working as expected

Testing Steps:
# Goto: Appearance -> Apply Seven theme
# Create any basic page
# Click on Menu setting and check on Provide a menu link
# Save the node
# Check the result

Expected Results:
# Check the Two possible ways to fix this which are mentioned in the issue summary and it should be working as per requirement.

Actual Results:
# Currently, No message is appearing before and after applying the patch

Please refer attached screenshots for the same.
Not working as expected.
Can be a move to Needs Work.

This came up as a bug smash triage target.

Rerolled.

Fixed the if/else to actually do what it is supposed to do, if the trimmed version of the provided title is empty -> set the title to the node title, in previous versions the trim did nothing.
We don't need to do the actual trimming since that is already handled by _menu_ui_node_save, so we only need to trim to check we actually end up with a valid title in _menu_ui_node_save.

Verified the patch #44 and tested it on Drupal version 9.5.x. The patch works fine and I have added the before and after screen recordings for reference.
Steps followed:-

• Create any basic page.
• Click on Menu setting and check on Provide a menu link.
• Remove the menu title generated automatically based on node title.
• Save the node.
• Check Main navigation menu.

After applying the patch, a menu link corresponding to the new node is autogenerated in the main navigation menu based on the node title even though the menu link title field was empty while creating the node.

Confirmed the issue on D10.1 by manually deleting the title field for the menu link.
Applied the patch and did the same steps and the menu link was created.

Unrelated fail

Option #2 seems good. Double checked the test coverage to make sure we actually have test coverage for removing a link, and that's fine.

I doubt there are lots of people using the bug to remove menu links as opposed to unchecking the checkbox, but going to just commit this to 10.1.x in case.

Committed 586900e and pushed to 10.1.x. Thanks!

This has been a bug so long, it has gotten a feature ... ;-)

In a project we rely on the old behaviour to realize a special workflow regarding creation of menu links while node editing. Now with the new behavior we have a bc break going from D9 to D10. Yes, I know this can happen going from D9 to D10.

I am also wondering if there might not be people that just clear the title to remove a menu link and then wonder why they get the menu link back even with different text if they changed the menu title before. And additionaly if you for example edit nodes from the content overview you will not get directed to the node view and might even not realize that this has happened.

I am not clearly seeing the bug in the old behavior and it was there for a long time ... But surely I have been 10 years to late for lamenting on this, but I really thought this behavior was intended the way it was.

I mean this is not straight forward:

You save a menu link with different title than the node title.
You come back later and remove the menu title and save the node.
You still have the menu link, but now with the node title again.