Hi,

GA Login has to attach itself to the login validators. Therfore, it hooks into the login form and overwrites the validator variable. However, this does bot work well, if the site is using different 2 factor systems at the same time. I used for example YubiKey and GA login. The better idea would be to unshift the validators and place the ga login validator at the correct position.

here the patch:
/**
@@ -265,12 +266,8 @@ function ga_login_test_form_submit($form, $form_state) {
*/
function ga_login_form_alter(&$form, &$form_state, $form_id) {
if ($form_id == 'user_login_block' || $form_id == 'user_login') {
- $form['#validate'] = array(
- 'user_login_name_validate',
- 'ga_login_user_login_validate',
- 'user_login_authenticate_validate',
- 'user_login_final_validate',
- );
+ array_unshift($form['#validate'],$form['#validate'][0]);
+ $form['#validate'][1] = 'ga_login_user_login_validate';

Comments

fixed in latest dev

PS: for future reference, it's easier for us if you upload the patch as a file ;-)

Status:Active» Fixed

ok. in future I will provide the files ;).
Only problem is, that I patched many things at once, so I would have to split the patches for the different issues.

thank you for your support.

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue summary:View changes

provided patch