Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Currently, proper attach/detach coverage is lacking in our JavaScript files. Also it might be nice to at least trigger some basic events (passing a reference to the current instance along) upon attach/detach).
Both should make the drupal core scripts more extensible and 3rd party friendly.
Individual files status
File clean-up | Detach/attach/events needed? | Issue | |
---|---|---|---|
misc/ | ajax.js | ? | ? |
authorize.js | ? | ? | |
autocomplete.js | ? | ? | |
batch.js | ? | ? | |
collapse.js | ? | ? | |
drupal.js | ? | ? | |
form.js | ? | ? | |
machine-name.js | ? | ? | |
progress.js | ? | ? | |
states.js | ? | ? | |
tabledrag.js | ? | ? | |
tableheader.js | Yes | #1764912: Fix regressions and further improve tableheader.js | |
tableselect.js | Yes | #1751308: Refactor tableselect.js | |
timezone.js | ? | ? | |
vertical-tabs.js | ? | ? | |
modules/ | block | ? | ? |
book | ? | ? | |
color | ? | ? | |
comment | ? | ? | |
contextual | ? | ? | |
dashboard | ? | ? | |
field/modules/text | ? | ? | |
field_ui | ? | ? | |
file | ? | ? | |
filter | ? | ? | |
locale | ? | ? | |
menu | ? | ? | |
node | ? | ? | |
openid | ? | ? | |
overlay | ? | ? | |
shortcut | ? | ? | |
simpletest | ? | ? | |
statistics | ? | ? | |
system | ? | ? | |
taxonomy | ? | ? | |
toolbar | ? | ? | |
user | ? | ? | |
themes/ | bartik/color | ? | ? |
Comments
Comment #0.0
Kiphaas7 CreditAttribution: Kiphaas7 commentedadding @todo
Comment #1
nod_Umm not too happy about the duplication. Please add the attach/detach comment to the issue summary of the other scripts (we already have 1 issue for each of those, most of them are still open).
If the issue is already closed, create a new one and link it underneath the previous one, (see what I did for tableheader).
A big table like that is pretty annoying to maintain and I don't want outdated ones in the issue queue. Thanks.
I'll let you close this one if you agree, otherwise ping me on IRC or leave a comment :)
Comment #2
Kiphaas7 CreditAttribution: Kiphaas7 commentedFine by me. I'll try to figure out which issues need the attach/detach and basic events.
Comment #3
nod_Thanks a lot :)
Makes me happy to see people undertake painful tasks like this one :)
Comment #3.0
nod_added table