Hi and firstofall thanks a lot for this absolutely great and useful module. I think it might become one of the big standard modules in the future. Thanks a lot for this.

Today I had a problem in combination with http://drupal.org/project/revisioning module. Firstofall no tabs where showing up, then tokens were not replaced.

After some debugging I found out the reason.
$router_item['page_arguments'][0] is not the $node object in my case.

I think the reason for that is that "revisioning" moves the node to a later position. Have a look at the attached screenshots of
1. $router_item
and
2. $router_item['page_arguments']

As a quickfix I changed $router_item['page_arguments'][0] to $router_item['page_arguments'][2] in my case but that can't be right:

ccl_local_actions.module, Line 132:

      if (!in_array($router_item['page_arguments'][2]->type, $link['visibility']['types'], TRUE)) {

AND
ccl_local_actions.module, Line 173:

$node = $is_node ? $router_item['page_arguments'][2] : NULL;

So it would be nice if you could have a look. Perhaps "$router_item['number_parts']" is always providing the correct index? I'm not sure.

Perhaps #1355740: Works with workbench_moderation has the same reason.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bkoether’s picture

I definitely will have a look at this.
Thanks for the detailed description!

Anybody’s picture

Status: Active » Needs work

Hello bkoether,

thanks a lot for that :) I think it is quite important.

Anybody’s picture

Issue summary: View changes

Fixed Info

bkoether’s picture

Issue summary: View changes
Status: Needs work » Closed (won't fix)

I'm closing this as no further feature development for the 7 branch will happen and no additional issues relating to this have been reported.