Notification e-mails are not send out to all experts [#1768656]

Repeatable: Always

Steps to repeat:

Download, install and activate FAQ module 7.x-1.0-rc2 and Faq_ask 7.x-1.x-dev
Setup a new user role and create some users with valid email-adresses with this role. Create a vocabulary and some terms you want to use for your FAQ
On /admin/config/content/faq/ask mark the checkbox "Notify Experts" and choose the vocabulary you want to use for your FAQ
On the same page, pick your newly created user role as "Expert Role"
Save the settings and after that (on the same page) match terms and experts in the checkbox matrix
Now go to node/add/faq?ask=TRUE and choose a term "x" and post the question

Expected Results:
All experts connected to term "x" should get a notification email

Actual Results:
Only user 1 is getting a notification email

Note:
In README.TXT it says "If notification of question creation is needed, use the Subscriptions module
set for the appropriate terms (FAQ categories)." This makes me wonder if the notify expert feature isn't supported in the version for D7? Well anyhow I am working on a patch for this (my first for drupal.org!) and hope it can be useful for others.

Comment	File	Size	Author
#1	Faq_ask-notifications_not_sent_to_experts-1768656.patch	1.29 KB	benjamin_dk
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

benjamin_dk CreditAttribution: benjamin_dk commented 1 September 2012 at 23:56

Status:

Active

» Needs review

File	Size
Faq_ask-notifications_not_sent_to_experts-1768656.patch	1.29 KB

Here's the patch - it makes sure the right field language property is used when accessing the selected term(s).

Comment #2

stenjo CreditAttribution: stenjo commented 28 September 2012 at 20:42

Status:

Needs review

» Needs work

It seems that I am able to re-create the issue you are describing, and have modified the test by adding a line at
faq_ask.test, approx line 684 that reads:

    $this->assertMail('to', $this->answer_user2->mail, t('E-mail was sent to expert 2: @mail', array('@mail' => $this->answer_user2->mail)));

After adding answer_user2 as another user with the expert role.
This line is failing and should not.
The patch you have submitted does not seem to fix this, however. The patch also creates another failure in the test that removes the category in the message sent to the experts.
This is probably a small mistake but needs to be fixed.
Please download and run the test using the last -dev version. Fix the bug and make sure the test is not failing.

Comment #3

Aivis CreditAttribution: Aivis commented 23 April 2013 at 06:38

Hello Dear stenjo. I experience same trouble here. I have already tried both stable and current dev versions of FAQ and FAQ_ASK modules. It does not help. Notifications are sent every time only to default Expert instead to experts for categories specified. Is there any solutions? Currently, I am using Drupal 7.21, Faq_Ask, 7.x-1.0-alpha1+4-dev and Faq 7.x-1.0-rc2+8-dev. Thanks in advance