When creating a theme for a site, people often override comment-wrapper.tpl.php which contains both the comments, and the comment form. It would be great if we had the option of adding an equivalent content pane to a node_view panel page, which rendered the comments and the form through the comment-wrapper.tpl.php.
This is a fairly common use case I'm trying to solve with panels:
[node content]
[something in between]
[comments and comment form]
Right now the comments and the comment form are two separate panes which means that by adding them separately we loose all the cusomizations that were made via the comment-wrapper.tpl.php, making it really difficult to maintain consistency across the whole site when some nodes are using the default display and some are overridden.
Comment | File | Size | Author |
---|---|---|---|
#7 | ctools-comment_wrapper_content_pane-1771088-7.patch | 3.97 KB | jenlampton |
#5 | interdiff.txt | 1.94 KB | IshaDakota |
#5 | comment_wrapper_content_pane-1771088-5.patch | 4 KB | IshaDakota |
#1 | comment_wrapper_content_pane-1771088-1.patch | 3.72 KB | jenlampton |
Comments
Comment #1
jenlamptonpatchy. and I guess this is a feature request.
Comment #2
etiennechataignier CreditAttribution: etiennechataignier commentedIt works like a charm. Thanks a lot @jenlampton !
Comment #3
jenlamptonThanks @echataig! Next time you review something and it works as expected, can you change the issue status to 'reviewed & tested by the community' for us? :)
Comment #4
japerryIt looks pretty good ,but needs some docblocks. Only has one review, and I'll add it to mine to review as well.
Needs Docblock
Needs Docblock
Needs Docblock
Needs Docblock
Comment #5
IshaDakota CreditAttribution: IshaDakota commentedAn attempt at docblocks (and one whitespace fix).
Comment #6
hideaway CreditAttribution: hideaway commentedI am dependant on this, will we get it commited to dev?
Comment #7
jenlamptonGreat job @IshaDakota!
I added some whitespace before the * in the docblocks, and also added a check to see if the comment module exists (taken from node_comments plugin). I also compared the docblocks in this plugin to a few others, which was hard since most of them don't have any (ahem, node_comments). The ones in this patch are the most common (and are almost exactly the same as what @IshaDakota had!) so... marking as RTBC.
Comment #8
hideaway CreditAttribution: hideaway commentedwhen this is pushed? it's already reviewed and working and it's nice feature. I am using this for quite a while, but I am afraid it never will be really added to the repo.
Comment #9
japerrySweet, sorry I missed the revised patch. Fixed.