The module needs to implement default rules for node expire unpublishing.

Refactor the existing rules to allow for more flexibility. Add a *.rules_default.inc file to enable default rules on install.

CommentFileSizeAuthor
#1 commerce_node_checkout_expire.rules_refactor.patch6.44 KBwadmiraal
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

wadmiraal’s picture

wadmiraal CreditAttribution: wadmiraal commented
Status: Active » Needs review
FileSize
commerce_node_checkout_expire.rules_refactor.patch6.44 KB

Patch.
Includes action refactoring and the new *.rules_default.inc file.

wadmiraal’s picture

wadmiraal CreditAttribution: wadmiraal commented

It will need a better email body for the reminders than what I've put in there.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented

Looks good, I agree on the body but I think that is something site admins will want to edit anyway. So we will need to add some doco to that effect.

Status: Needs review » Needs work

The last submitted patch, commerce_node_checkout_expire.rules_refactor.patch, failed testing.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Status: Needs work » Fixed

committed to 7.x-1.x branch.
Also fixed the fatal error in the sub-module and cleaned up for coding standards.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented

(btw the failing test is most likely because of your line-endings settings - but I resolved and it applied cleanly)

wadmiraal’s picture

wadmiraal CreditAttribution: wadmiraal commented

Oops, a Fatal Error !? Didn't see that :-). Line endings ? Could be...just switched to Sublime Text...have to check some settings.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented

The fatal was there before the patch :)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.