I'd suggest that we need to introduce a new permission access users overview that grants access to admin/people, similar to how node.module has a access content overview permission. This allows for easier management without needing to grant the all powerful administer users permission, or knowing that the create user page is located at /admin/people.

Files: 
CommentFileSizeAuthor
#2 1776666.3-administerusersbyrole-access-users-overview-permission.patch1.19 KBmrfelton
PASSED: [[SimpleTest]]: [MySQL] 1,141 pass(es).
[ View ]
#1 1776666-administerusersbyrole-access-users-overview-permission.patch1.28 KBmrfelton
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1776666-administerusersbyrole-access-users-overview-permission.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Comments

Status:Active» Needs review
StatusFileSize
new1.28 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1776666-administerusersbyrole-access-users-overview-permission.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

This should work, but it's not in mysetup. Well, it works for admin/people/people, but not for admin/people.

StatusFileSize
new1.19 KB
PASSED: [[SimpleTest]]: [MySQL] 1,141 pass(es).
[ View ]

Oops, here it is against a clean checkout (I had another patch applied when I created that)

Status:Needs work» Needs review

Actually, this does work perfectly. My issue was because I also had admin_views installed. I resolved by adding the following to my own module:

<?php
/**
* Implements hook_views_default_view_alter().
*/
function mymodule_core_views_default_views_alter(&$views) {
  if (isset(
$views['admin_views_user'])) {
   
// Adjust the permissions for the people admin screen so that users with
    // administerusersbyrole's 'access users overview' can access.
   
$handler =& $views['admin_views_user']->display['default']->handler;
   
$handler->display->display_options['access']['type'] = 'perm';
   
$handler->display->display_options['access']['perm'] = 'access users overview';
  }
}
?>

Should we apply this patch #2 or not?

Status:Needs review» Needs work

I think we might need an upgrade path - one that grants the new permission to all users that hav the administer users permission.

Status:Needs review» Needs work