XHProf -dev on Drupal 7.15 throws a fatal error when you try to sort any column from a xhprof run table. Patch coming up :)

CommentFileSizeAuthor
#1 1776758.patch2.08 KBamateescu
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

amateescu’s picture

amateescu CreditAttribution: amateescu commented
Status: Active » Needs review
FileSize
1776758.patch2.08 KB

Here we go.

amateescu’s picture

amateescu CreditAttribution: amateescu commented
Title: Inproper usage of theme('tablesort_indicator') » Improper use of theme('tablesort_indicator')

Even with better english!

msonnabaum’s picture

msonnabaum CreditAttribution: msonnabaum commented

Happy to fix this if I'm using the api wrong, but I definitely can't recreate the fatal error. What was the error you were getting?

amateescu’s picture

amateescu CreditAttribution: amateescu commented

This was the error: Fatal error: Unsupported operand types in D:\xampp\htdocs\cartier\www\includes\theme.inc on line 1071

It was trying to mix the 'desc' string with an array.

Edit: Also, the documentation says that theme_tablesort_indicator() requires an array.

msonnabaum’s picture

msonnabaum CreditAttribution: msonnabaum commented
Status: Needs review » Fixed

Fair enough. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.