Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
After fixing the tests with #1764516: Repeated functions / Syntax error., if the deploy module is not downloaded, the tests fail when trying to enable it. Also there is a test case (Import UUID entities, without deploy) that depends on entity and features and has the same problem.
Proposed solution:
Add a dependencies key to the tests that use this module so they don't get executed when it's not there.
Note that this won't affect the behavior of the test bot since it automatically detects and downloads the dependency.
Comment | File | Size | Author |
---|---|---|---|
#1 | uuid-add_tests_optional_dependencies-1777980-1.patch | 1.31 KB | lucascaro |
Comments
Comment #1
lucascaro CreditAttribution: lucascaro commentedAttached is a patch that does what I mentioned. Note that the tests are still failing (in particular the tests on UUIDSyncTestCase) but that deserves a different issue IMHO.
Comment #2
lucascaro CreditAttribution: lucascaro commentedComment #3
lucascaro CreditAttribution: lucascaro commentedComment #4
mgiffordPatch still applies nicely to the git repo. This seems like a nice simply improvement to the testing infrastructure, but not sure what's the best way to test this to mark it RTBC. Is it simply running this module's simpletests?
Comment #5
lambic CreditAttribution: lambic commentedAfter applying the patch I still get 2 failures in UUIDImportEntitiesWithoutDeploy:
Fail Other uuid.test 635 UUIDImportEntitiesTestCase->testImp
uuid_entities in uuid_default_entities_example had state: default
Fail Other uuid.test 659 UUIDImportEntitiesTestCase->testImp
uuid_entities in uuid_default_entities_example had state: default
But this patch fixes the more fatal failures.