I am getting an E_STRICT warning after creating a short url.

Strict warning: Only variables should be passed by reference in shurly_rate_limit_allowed() (line 596 of /private/var/www/drupal7/docroot/sites/all/modules/shurly/shurly.module).
CommentFileSizeAuthor
#1 shurly-php-warning-1778558-1.patch947 bytesmakangus
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

makangus’s picture

makangus CreditAttribution: makangus commented
FileSize
shurly-php-warning-1778558-1.patch947 bytes

This should fix it for the paranoid folks

makangus’s picture

makangus CreditAttribution: makangus commented
Status: Needs work » Needs review
Pasqualle’s picture

Pasqualle
Location 🇭🇺 Budapest
CreditAttribution: Pasqualle commented
Status: Needs review » Reviewed & tested by the community

patch looks good

JamesOakley’s picture

JamesOakley
he/him/his
Primary language English
Location Kent, UK
CreditAttribution: JamesOakley commented

Has this been committed yet?

liza’s picture

liza CreditAttribution: liza commented
Issue summary: View changes

Am getting this message at a different line : 

Strict warning: Only variables should be passed by reference in shurly_validate_long() (line 766 of [...] shurly\shurly.module)
Jibus’s picture

Jibus CreditAttribution: Jibus commented
Status: Reviewed & tested by the community » Closed (fixed)

Committed against 7.x-1.x and 6.x-1.x Thanks !

Liza, do you have still this warning ? If so, could open a new ticket ? Thanks !