Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
When using a week view of calendar, the events in 7th day (depending on which day is set the first day of a week, this could be Saturday or Sunday) will not be shown. I think it's due to an error in the for loop in the template. I've made a patch to fix it.
Just for some information on how to reproduce the issue: I've set the first day to Monday and the calendar week view doesn't show any events in Sunday.
Comment | File | Size | Author |
---|---|---|---|
calendar-week.tpl_.php_.patch | 939 bytes | andyhu | |
#4 | calendar-7thdayeventdisplay-1779142-4.patch | 686 bytes | torpy |
Comments
Comment #1
arlinsandbulte CreditAttribution: arlinsandbulte commentedNote: Marked #1712290: Events dont show up in all day field as a duplicate of this issue.
Comment #2
andyhu CreditAttribution: andyhu commentedhas anyone experienced the same issue? if the patch works, can we get it committed since it's a quite obvious bug?
Comment #3
zeit_geist CreditAttribution: zeit_geist commentedSame thing here: multi-day event not showing up in weekly view when starting on Sunday.
I confirm the solution works great. Thx for @andyhu
Comment #4
torpy CreditAttribution: torpy commentedUpdated the patch so that it applies cleanly from inside the module directory instead of relying on a specific site structure.
Comment #5
hcethatsme CreditAttribution: hcethatsme commentedI'm confused. https://www.drupal.org/node/1989892 shows the issue fixed on 7.x-3.4, but is that a mistake? The code in 7.x-3.5 and 7.x-3.x still has the loop going from 0 to 5 only AFAICT. torpy's patch works perfectly. Can this be committed?
Comment #6
AlyssaMc CreditAttribution: AlyssaMc commentedThis patch stopped working when we updated to Drupal 7.39. Anyone else experiencing the same issue?
Comment #7
mrcharles CreditAttribution: mrcharles commentedI seem to have this issue as well...
Comment #8
Lisaumd CreditAttribution: Lisaumd commentedSame for me. I edited the patch content into my template and still had to restore the Dates modules back to to see events on day 7. Now I can see the events but I have no up or down arrows for the date, and I have 4 events so I should have a arrows in the display. Other days, with multiple events, display the up and down arrows correctly. Any ideas?
Comment #9
jeffmasigan CreditAttribution: jeffmasigan commentedI experienced the same issue when I did some updates. I was already on Drupal 7.39 and my Calendar module was at version 7.x-3.5.
One of the modules I updated was the Date module I was on 7.x-2.8 then I updated to 7.x-2.9 and the last day on my Calendar on week view stopped working. I've read some other forums that other days weren't showing up but it's the same issue because they had a different day of the week as their start day.
I fixed the issue by restoring a back-up of my website and updating everything but the Date module and things worked. Issue is probably a combination fix for Date and Calendar modules - or an issue with the calendar-week.tpl.php template.
Hope that helps!
Comment #10
mrcharles CreditAttribution: mrcharles commented@jeffmasigan Exactly right. The issue is with the update of Date module to 7.x-2.9 from 2.8 breaks the last day of the week on the calendar.
Comment #11
Nelson Lago CreditAttribution: Nelson Lago as a volunteer commentedI am not sure if this is the same bug reappearing or a different bug with the same symptom. In any case, this one seems to be a duplicate: www.drupal.org/node/2580921 and this one seems to be the cause: www.drupal.org/node/1137062 .
Comment #12
Lisaumd CreditAttribution: Lisaumd commentedI had this issue, applied the patch in the template, restored to the previous Dates module and now I see the last day of the week in the week view but not the up or down arrows on that day. I have multiple events and the up and down arrows work for other days of the week just not Saturday. Any suggestions?
Comment #13
jeffmasigan CreditAttribution: jeffmasigan commentedI have applied patch from #27 - https://www.drupal.org/node/1137062 and it worked
Comment #14
jeffmasigan CreditAttribution: jeffmasigan commented@Lisaumd - could you share what your template looks like?
Comment #15
Dave Gray CreditAttribution: Dave Gray commented#27 is working well for us!
Comment #16
SeanA CreditAttribution: SeanA commentedComment #17
bgrobertson CreditAttribution: bgrobertson commentedJust wanted to note, while applying patch that jeffmasigan mentions in #13 fixed normal events on the 7th day not showing up for me, it did not fix All Day events not showing up on the seventh day for me. I had to apply both patchs (#13 and #4) to fix this issue. I am using custom time groupings for my week view, which may be coming into affect.
Comment #18
marcoscanoIn my case only applying the patch in #2673192-2: Modify remaining days to match Date week range patch was enough to completely solve the problem.
Comment #19
Lisaumd CreditAttribution: Lisaumd commentedWe got it fixed, still on Date 7.x-2.8. What template did you want to see? I don't have file access but I think I get what you want to see and I'll try to get it posted here.
Comment #20
ianfunghk CreditAttribution: ianfunghk commentedNo longer required to fix after applying patch from Date API, Date module. Ref:https://www.drupal.org/node/1137062
Comment #21
Anonymous (not verified) CreditAttribution: Anonymous at Cheeky Monkey Media commentedWith ianfunghk saying this was fixed by another patch, I'm thinking this should be marked as duplicate of https://www.drupal.org/node/1137062
Comment #22
Mykola Dolynskyi#27 dont work, Date API 7.x-2.10, Calendar 7.x-3.5
@marcoscano ++, calendar-modify_remaining_days-2673192-2.patch (from Modify remaining days to match Date week range patch ) also helped in my case, thanks
Comment #23
catapipperThe patches for Date and Calendar mentioned in the comments above solved the issue for all scenarios except for one which is very specific and still needed the patch found here.
Specifics of scenario where this patch is only solution:
Thank you again for this patch!
Comment #24
varenius CreditAttribution: varenius commentedI can confirm this is still a problem with the most recent Drupal 7.67, Calendar 7.x-3.5 and Date 7.x-2.10. Changing the lines suggested in the two patches
https://www.drupal.org/files/issues/2018-08-21/date-n1137062-65.patch
https://www.drupal.org/files/issues/calendar-7thdayeventdisplay-1779142-...
solves the problem for me.