Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I cannot find any case about this, but I get this message on the needs review and my content tab. I'm not sure what exactly this means nor what I can do to get rid of it.
Debug:
'Handler workbench_access_handler_field_section tried to add additional_field nid but node could not be added!'
in views_handler_field->add_additional_fields() (line 142 of sites/all/modules/views/handlers/views_handler_field.inc).
What should I do?
Comment | File | Size | Author |
---|---|---|---|
#69 | view-export-1781744-64.patch | 31.71 KB | hass |
#64 | view-export-1781744-64.patch | 31.72 KB | stevector |
#60 | workbench_moderation-1792144-26_1.patch | 11.44 KB | hass |
#37 | workbench_moderation_main_title_display-1781744-37.patch | 11.46 KB | tglynn |
#41 | workbench_moderation_main_title_display2-1781744-37.patch | 11.43 KB | tglynn |
Comments
Comment #1
cardentey CreditAttribution: cardentey commentedI have the same issue.
Comment #2
iStryker CreditAttribution: iStryker commentedWhat version of views are you using?
Comment #3
hass CreditAttribution: hass commentedViews 7.x-3.5
Comment #4
iStryker CreditAttribution: iStryker commentedWorkbench does not work with views 3.5 (or the short lived 3.4). Can you check if #1782172: In views 3.5 Title etc are not showing anymore fixes this problem. I have recreated the default view for the Needs review tab (and My Drafts). The nid was on of the troubled field.
As for the My Content tab, you may still have a problem. My Content tab is a seperate view, which I have not changed.
Comment #5
hass CreditAttribution: hass commentedRollback to Views 3.3? :-(
Comment #6
iStryker CreditAttribution: iStryker commentedThe 'Need Reviews' and 'My Drafts' tabs are Workbench Moderation module
The 'My content' is Workbench module
Maybe an issue should be open in Workbench (if there is not one already)
Comment #7
h4rrydog CreditAttribution: h4rrydog commentedI tried applying the patch in #4 #1782172: In views 3.5 Title etc are not showing anymore but it did not fix the issue. Reluctantly rolled back to Views 3.3 which does restore functionality.
Comment #8
tkngdwn CreditAttribution: tkngdwn commentedThis seems to be related to Workbench Access directly. I noticed in workbench_access_handler_field_section.inc that the table referenced is node_revisions, which should be node_revision. Changing this will display sections properly, however it also seems to cause a variant of duplicated items without any fields in the My Edits section. I'm still trying to figure out what could be causing it to spit out empty rows though.
Comment #9
hass CreditAttribution: hass commentedComment #10
tkngdwn CreditAttribution: tkngdwn commentedOk, so I think I have a solution for this for Views 3.5. This fix sort of spans across Workbench, Workbench Access, and Workbench Moderation as it involves views provided by them. You may need to disable and re-enable the modules for the changes to take effect.
In workbench_access/views/workbench_access_content.view.inc
Change:
To:
Then for a very quick fix you can edit the views (workbench_edited, and workbench_moderation) provided by the Workbench modules, it will tell you it has fixed the relationships. You only then need to change the relationship for 'Content revision: Content' to be required and save.
To change this in the code you can do the following:
In workbench/workbench_edited.view.inc
Change:
To:
Append a line to the following field and filter sections:
Field: COUNT(Content: Nid):
Field: Content: Title:
Field: Content: Type:
Field: Content: Published:
Field: Content: Updated date:
Field: Content: Edit link:
Sort criterion: Content: Updated date:
Filter criterion: Content: Title:
Filter criterion: Content: Type:
Filter criterion: Content: Published:
In workbench_moderation/views/workbench_moderation.view.inc
Change:
To:
Append a line to the following field and filter sections:
Field: Content: Nid:
Field: Content revision: Log message:
Field: Content: Title:
Field: Content: Type:
Field: Content: Updated date:
Sort criterion: Content: Updated date:
Filter criterion: Content: Title: (Note: There are three of these sections. Append to all.)
Filter criterion: Content: Type: (Note: There are three of these sections. Append to all.)
Filter criterion: Content: Published:
If anyone wants to roll these changes into patches that would be great.
Comment #11
hass CreditAttribution: hass commentedCan you create patches, please? This is really heavy list of code changes to do by hand.
Comment #12
tkngdwn CreditAttribution: tkngdwn commentedThe current 1.x Git version of Workbench Access actually already has the proper changes for the node_revision table. The patches for the other two are attached.
Comment #13
hass CreditAttribution: hass commentedModules are no longer usable and completly broken. Marking as critical. We need new releases.
Comment #15
hass CreditAttribution: hass commentedComment #16
hass CreditAttribution: hass commented#12: workbench.patch queued for re-testing.
Comment #18
hass CreditAttribution: hass commentedWorkbench core patch has been moved to #1792144: "My Edits" View is broken for green light.
Re-attaching for robot to get the green light.
Comment #19
hass CreditAttribution: hass commented@tkngdwn: Your patch is working great for me! THX!!!
Comment #20
tkngdwn CreditAttribution: tkngdwn commentedGlad it worked. Makes upgrading the module easier for me in the long run. =D
Comment #21
hass CreditAttribution: hass commentedWe definitively need new releases with this patches included! :-)
Comment #22
iStryker CreditAttribution: iStryker commentedDoes this address comment #4 issue as well?
Comment #23
tkngdwn CreditAttribution: tkngdwn commentedI believe it does. That was one of the issues I was experiencing as well and it all seems ok now.
Comment #24
iStryker CreditAttribution: iStryker commentedNope! Does not solve comment #4 in #1782172: In views 3.5 Title etc are not showing anymore. You need to create a new relation from workbench_moderation_history.nid to node.nid, not node_revision.nid to node.nid which was one of the things I did in the other issue.
Comment #25
hass CreditAttribution: hass commentedI see all titles. Clear your caches and reset your customized views, please. You may need to share some screenshots.
Comment #26
iStryker CreditAttribution: iStryker commentedIf you publish something then save it as a draft or need reviews it doesn't show up
Comment #27
iStryker CreditAttribution: iStryker commentedComment #28
iStryker CreditAttribution: iStryker commentedOk I have simplified my patch from #1782172
I've also change nid_1 field to nid
I believe there are alot of extra information in the default view, which should be stripped out, but I'll leave that for another issue
Comment #29
hass CreditAttribution: hass commentedWe should not mix issues. You may identified a bug, but it must be a different bug. Let's open a new issue, please.
Comment #30
romaingar CreditAttribution: romaingar commentedHi,
THe patch is working for me but be careful to disable the module "content access", because it's not compatible with workbench moderation...
Comment #31
hass CreditAttribution: hass commentedHow about writing some tests for these bugs? The module seems to have some real reliability issues to me. It's fairly difficult to trust that everything works properly. It least me is loosing trust.
Comment #32
iStryker CreditAttribution: iStryker commentedI have done some testing for Patch in #28
1.1 Create -> Save as draft (draft is default option)
My Edits: Present
All Recent Content: absent (until publish it queries node table not node revision)
My Drafts: present
Needs Review: absent
1.2 Create -> Save as draft -> Change to Needs Review
My Edits: present
All Recent Content: absent (until publish it queries node table not node revision)
My Drafts: present
Needs Review: present
1.3 Create -> Save as draft -> Change to Needs Review -> Change to Published
My Edits: present
All Recent Content: present
My Drafts: present (shows as published state) see #1630682: "My Drafts" tab should not list published content
Needs Review: absent
1.4 Create -> Save as draft -> Change to Needs Review -> Change to Published -> Click New Draft -> Save as Draft
My Edits: present (showing the published title and fields, but updated date of draft)
All Recent Content: present (showing the published title and fields, but updated date of draft)
My Drafts: present
Needs Review: absent
This is identical as Patch #18 except for 1.4 - My Drafts: absent
Cannot fix 1.1 & 1.2 All Recent Content, as this is part of the workbench module
Comment #33
Bevan CreditAttribution: Bevan commented#1601036: Views: Use LEFT JOIN not INNER was marked as duplicate.
Comment #34
Taxoman CreditAttribution: Taxoman commentedThere is also patch/code in the duplicate issue mentioned in #33:
#1601036: Views: Use LEFT JOIN not INNER ,
- and ref. this Views issue:
#1766338: Incorrect filter group OR behavior, LEFT JOIN changed to INNER JOIN
Comment #35
oschuetze CreditAttribution: oschuetze commentedThe same error message will be still displayed on the tabs "My Drafts" and "Needs Review" of My Dashboard.
The other error messages have been solved successfully by this patch and this patch.
Comment #36
iStryker CreditAttribution: iStryker commented@oschuetze is correct, one patch for workbench_moderation module, the other for workbench module.
Comment #37
tglynn CreditAttribution: tglynn commentedI manually applied the dev patch into my Workbench Moderation 7.x-1.1 code. It worked for me, so I've attached the patch here.
Comment #38
tglynn CreditAttribution: tglynn commentedI'm changing the version back to dev. Didn't mean to change the version for the whole topic.
Comment #40
hass CreditAttribution: hass commentedComment #41
tglynn CreditAttribution: tglynn commentedHere I have edited the file so that, hopefully, there are only unix line endings, as the patch check complained about a moment ago.
Comment #42
hass CreditAttribution: hass commentedPlease stop posting patches for NON-DEV versions that clutters this case. Keep them on your computer.
Latest patch is in #28.
Comment #43
tglynn CreditAttribution: tglynn commentededited
Comment #44
zunaeid CreditAttribution: zunaeid commentedThere are two typos for node_revision.
http://drupal.org/node/1735382
This worked for me. Thank you
Comment #45
TimG1 CreditAttribution: TimG1 commented+1 to #44. Looks like #1735382: Typo for node_revision in active section Views field handler has been committed.
Downloading the dev version of Workbench Access worked for me.
-Tim
Comment #46
rosborn CreditAttribution: rosborn commented#44's solution worked for me as well. Trying to avoid going back to dev versions, so I hope this can be included in a new release soon.
Comment #47
Sborsody CreditAttribution: Sborsody commentedInstalling the dev version of Workbench Access as per #44 fixed the error for me yet now it isn't clear if the patch in #28 is really needed.
Views 3.5, Workbench Access 7.x-1.x-dev, Workbench Moderation 7.x-1.2
Comment #48
wrd CreditAttribution: wrd commentedInstalling dev version of Workbench Access solved the error problem for me, but also removed the option to select Taxonomy as an access scheme; can now only select Menu.
Comment #49
zhangtaihao CreditAttribution: zhangtaihao commentedIf updating Workbench Access to 7.x-1.x-dev fixes this issue, let's mark it as either "fixed" of "closed (duplicate)" (of #1735382: Typo for node_revision in active section Views field handler).Never mind.Comment #50
zhangtaihao CreditAttribution: zhangtaihao commented#28 fixes the missing columns. Some issues noted:
I suspect the third point can be solved simply by re-exporting the view entirely.
Also, I should probably point out that Views 7.x-3.5+6-dev has the new node-revision relationship using "nid" instead of "vid". Might it be worth using that instead?
Comment #51
operinko CreditAttribution: operinko commentedAs for the view issue, it seems that the "Editing marks it as 'changed'" issue is caused by some missing/wrong relationships (I seem to recall a message about Views having added missing relations automatically)
Comment #52
agentrickardI'm coming into this issue cold, but with commit access.
I cannot replicate the issue, using:
Can someone provide simple steps to replicate?
I need explicit lists of modules and versions. Actions taken. URLs where the error appears. Etc.
Comment #53
bbinkovitz CreditAttribution: bbinkovitz commentedI replicated this issue using Workbench 7.x-1.x-dev and Views 7.x-3.x, but it did not persist when I switched from Views 7.x-3.x-dev. I think it's a Views issue that was fixed in dev.
Comment #54
hass CreditAttribution: hass commentedWorkbench Moderation 7.x-1.2
Workbench Access 7.x-1.0
Workbench 7.x-1.1
Views 7.x-3.5
Comment #55
agentrickardThanks. If it's a Views issue, I don't know what we can do about it except nudge the Views maintainers.
Comment #56
rosborn CreditAttribution: rosborn commentedI thought this was a Workbench Access issue #1735382: Typo for node_revision in active section Views field handler, which has now been fixed. Fixing the typo referenced there (see #44) got rid of the error message that was listed in the initial issue. The problem for me is that Workbench Access hasn't had a release since August 2011, and I'm not willing to go back to dev versions on my production site.
Comment #57
agentrickard@rosborn
There are issues in the Workbench Access queue marked "Needs Review" -- they are release blockers. -dev is perfectly stable if you are using Taxonomies.
Comment #58
hass CreditAttribution: hass commentedThis here is not an issue of workbench access and and upgrade to dev does not solve the issues reported here!
Comment #59
mpruitt CreditAttribution: mpruitt commented#12: workbench.patch queued for re-testing.
Comment #60
hass CreditAttribution: hass commentedLatest patch in #28 has a problem, but I'm not sure if we should handle this here. This can be a follow up issue.
In
admin/workbench/needs-review
a user will see all nodes from all sections he is assigned, too. But this user do not have permission to change moderation state of any of this nodes. He is only able to change moderation state on his own nodes. This nevertheless show the Draft link in Moderation column.A node should only be listed in
admin/workbench/needs-review
if the user has permission to change the moderation states.I'm reattaching the latest patch (unchanged) from #28 as it may not clear to many that this is the LATEST patch and I hate reading all again and again.
Comment #61
hass CreditAttribution: hass commentedWorks all as required and fixes tons of issues. Other bugs can be handled in follow up issues.
Let's make this modules usable and commit this patches + release a new version now, please.
Comment #62
hass CreditAttribution: hass commentedMarked #1880420: revisions of existing nodes not showing up in "needs review" view as duplicate.
Comment #63
stevectorTagging for Workbench Sprint to get this resolved this week.
Comment #64
stevectorAfter applying this patch and clicking edit on the View I'm still getting a notice that there are unsaved changes. After reexporting I get a number of lines changed in the diff. hass, are you seeing the same behavior?
Here's the re-exported patch. I made no manual changes, just applied #60, hit edit and hit save. I'm on a git checkout of Views 7.x-3.x.
Also can you jump in #drupal-workbench to discuss issues tagged with the "Workbench Sprint."
Comment #65
hass CreditAttribution: hass commentedThat's correct. There have been changes in the views api. The previous patch only fixed the issues, but I'm fine if we export the full view. That does not change anything, but bring us on top of latest views changes.
We can see the same in #1569698: Re-export default Views and I noted this in #1630682: "My Drafts" tab should not list published content
Comment #66
stevectorAlso hass, in 58 you mention that the dev version of Workbench Access doesn't fix the error message reported here. Is that right?
I am not seeing "Handler workbench_access_handler_field_section tried to add additional_field nid but node could not be added!" As has been mentioned by other commenters, that error message should have gone away with http://drupal.org/node/1735382 which is in the dev version of Workbench Access.
Comment #67
hass CreditAttribution: hass commentedLast test was made with WBA 7.x-1.0+35-dev + a view patches like the one mentioned from queue. Will update now. I just tested all with latest DEV and confirmed that this does not fix the issue here without the patch applied from this case.
There are table column values missing in needs review and draft view and so on and so on.
Comment #68
hass CreditAttribution: hass commentedneed to remove the space
same
Comment #69
hass CreditAttribution: hass commentedFixed patch directly
Comment #70
stevectorSo hass, you are seeing somewhere the error message "Handler workbench_access_handler_field_section tried to add additional_field nid but node could not be added!"
Can you give me more specific instructions for how to reproduce that specific error? Or is the title of this issue just out of date?
Comment #71
hass CreditAttribution: hass commentedReproduced all again with WB 1.1, WBM 1.2, WBA 1.0:
URL
admin/workbench/drafts
URL
admin/workbench/needs-review
Additional:
admin/workbench/needs-review and admin/workbench/drafts is completely broken. Many columns are missing text.
Comment #72
hass CreditAttribution: hass commentedReproduced all again with WB 1.1, WBM 1.2, WBA 7.x-1.0+55-dev:
Issues disappeared on Needs review and Draft pages.
Stil broken:
admin/workbench/needs-review and admin/workbench/drafts is completely broken. Many columns are missing text.
We used this case title to catch the people who are running official released versions. Changing the title now.
Comment #73
hass CreditAttribution: hass commentedReproduced all again with WB 1.1, WBM 7.x-1.2+9-dev, WBA 7.x-1.0+55-dev:
No changes to #72
Comment #74
hass CreditAttribution: hass commentedReproduced all again with WB 7.x-1.1+7-dev, WBM 7.x-1.2+9-dev, WBA 7.x-1.0+55-dev:
URL
admin/workbench
:This is #1792144: "My Edits" View is broken.
Workbench Moderation - Draft and Needs review pages, no changes - still broken.
Comment #75
hass CreditAttribution: hass commentedNote, all these tests have been made with latest Views DEV.
Comment #76
stevectorFixed: http://drupalcode.org/project/workbench_moderation.git/commit/22c46daf6e...
Thanks all!
Comment #77
stevectorI did one more commit to take out the Aggregation settings because they aren't getting used anywhere and clutter the UI.
http://drupalcode.org/project/workbench_moderation.git/commitdiff/059925...
Comment #78
cweagansFor anyone finding this later, to make this message go away, you have to upgrade both workbench and workbench moderation to the -dev releases until there's a release after today's date.
Comment #79
hass CreditAttribution: hass commentedDo not miss Workbench Access DEV...
Comment #80
capellicI just discovered Workbench and Workbench Moderation a couple of days ago and stumbled upon this problem. I found this case and others and was very happy to read #78. I updated to the dev versions and all is working as expected. THANKS!
Comment #81
romaingar CreditAttribution: romaingar commentedHI,
I used an older version of WB, WB Access and WB Moderation. ANd i had some problems with the view "need review". I have uninstalled these 3 modules and enabled the new one. Now it's strange... in the view admin i can view my results in the preview area, but not inside the page.... even if i'm connected as admin.
I've seen that some exposed filter are added to the view (section) "need review".
On the other hand i use domain access module, maybe it's the cause.
Sorry for my poor english... an if it's not the good place to post this.
Comment #82
stevectorHi Romaingar,
Since this issue is marked as fixed, I recommend opening as separate support issue.