A plugin for the urlencode() function would be helpful. Patch forthcoming for 6.x and 7.x

CommentFileSizeAuthor
#10 feeds_tamper-url_en_de_code_plugins-10.patch3.21 KBacrollet
#7 feeds_tamper-url_en_de_code_plugins-7.patch1.6 KBacrollet
#5 urlencodeplugin-1784052-5.patch820 bytesJohn Bickar
#4 urlencodeplugin-1784052-4.patch821 bytesJohn Bickar
#2 urlencodeplugin-1784052-2.patch1.85 KBJohn Bickar
#1 urlencodeplugin-1784052-1.patch838 bytesJohn Bickar
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

John Bickar’s picture

John Bickar CreditAttribution: John Bickar commented
FileSize
urlencodeplugin-1784052-1.patch838 bytes

Patch for 6.x-1.x-dev

John Bickar’s picture

John Bickar CreditAttribution: John Bickar commented
FileSize
urlencodeplugin-1784052-2.patch1.85 KB

Patch for 7.x-1.x-dev

John Bickar’s picture

John Bickar CreditAttribution: John Bickar commented

Oops, ignore those patches above. Better ones coming shortly.

John Bickar’s picture

John Bickar CreditAttribution: John Bickar commented
FileSize
urlencodeplugin-1784052-4.patch821 bytes

Patch for 7.x-1.x

John Bickar’s picture

John Bickar CreditAttribution: John Bickar commented
FileSize
urlencodeplugin-1784052-5.patch820 bytes

Patch for 6.x-1.x

John Bickar’s picture

John Bickar CreditAttribution: John Bickar commented
Status: Active » Needs review

Forgot about this. Looks like I forgot to set status.

Go, testbot. We'll see if they still apply ;)

acrollet’s picture

acrollet CreditAttribution: acrollet commented
Issue summary: View changes
FileSize
feeds_tamper-url_en_de_code_plugins-7.patch1.6 KB

Great patch! Submitting a re-roll for 7.x that also includes a urldecode plugin.

acrollet’s picture

acrollet CreditAttribution: acrollet commented
Title: urlencode plugin » url{en,de}code plugins
Version: 6.x-1.x-dev » 7.x-1.x-dev
twistor’s picture

twistor CreditAttribution: twistor commented
Status: Needs review » Needs work
Issue tags: +Needs tests

Looks good!

Needs a simple test for each, and the @file's need to be fixed.

acrollet’s picture

acrollet CreditAttribution: acrollet commented
Status: Needs work » Needs review
Issue tags: -Needs tests
FileSize
feeds_tamper-url_en_de_code_plugins-10.patch3.21 KB

Thanks for the feedback, updated patch attached.

The last submitted patch, 1: urlencodeplugin-1784052-1.patch, failed testing.

The last submitted patch, 2: urlencodeplugin-1784052-2.patch, failed testing.

The last submitted patch, 4: urlencodeplugin-1784052-4.patch, failed testing.

The last submitted patch, 5: urlencodeplugin-1784052-5.patch, failed testing.

twistor’s picture

twistor CreditAttribution: twistor commented
Status: Needs review » Fixed

Added an option to use rawurldecode().

Thanks!

  • twistor committed e6d1c1f on 7.x-1.x authored by acrollet 
    Issue #1784052 by John Bickar, acrollet: Added url{en,de}code plugins.
twistor’s picture

twistor CreditAttribution: twistor commented
Status: Needs review » Fixed

Rage.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.