simplify field_name variable [#1784508]

        foreach (field_info_instances('commerce_product', $type) as $name => $instance) {
          // A field qualifies if it is single value, required and uses a widget
          // with a definite set of options. For the sake of simplicity, this is
          // currently restricted to fields defined by the options module.
          $field = field_info_field($instance['field_name']);

$instance['field_name'] is also just the $name.

Though that would probably be better called $field_name.

Comment	File	Size	Author
#3	1784508-3.field_name.patch	1.65 KB	rszrama
#3

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

thomaske CreditAttribution: thomaske commented 21 September 2012 at 02:01

I cloned the 7.x.1 structure and searched the files for the offending code.

I found what appears to be the code in a module called commerce_product_controller.inc.

But the reference does not have the comments found in the quoted section. And it appears that if you change the name of the variable, it will overwrite a variable with the same name listed a few lines earlier.

Has it been changed significantly in the .dev version? Please advise.

Comment #2

joachim CreditAttribution: joachim commented 21 September 2012 at 09:31

I can see it in the latest dev.

Search for the string 'A field qualifies if it is single value'

Comment #3

rszrama CreditAttribution: rszrama commented 16 November 2012 at 02:49

Status:

Active

» Needs review

File	Size
1784508-3.field_name.patch	1.65 KB

I'm hesitant to change this. It's a bit of "if it ain't broke, don't fix it." As far as I was concerned, "$name" was the instance name - but it was mostly just a throwaway key value (you can see it isn't used anywhere inside that loop). However, looking at _field_collate_fields(), it is in fact keying the array per bundle by the instance field name. We'll make sure it passes test bot, and I suppose there's no reason not to change it.

A file name next time would help. ; )