fixed a couple issues, moved Remove to buddylist and simplified some language [#178605]

corrected some @Buddy List to @Buddylist
moved the Remove from a user profile page to the users buddylist
removed the pending from the user profile page
simplified the text on the buddylist pending if no sent or received pending
to None.

Comment	File	Size	Author
	buddylist_9.patch	6.45 KB	dsp1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

dldege CreditAttribution: dldege commented 15 October 2007 at 16:34

Finally got a look at this. There is some good stuff in here but a few things to discuss and fix.

1. A couple of these things have been fixed in other commits so a new patch needs to be created.
2. I'm ok with adding in the "remove" link but I'd like comments from other users about this since it could be done in your own theme is desired. Also, you need to change how its done

$rows[] = array(theme('username', user_load(array('uid' => $buddy['uid']))), theme('buddylist_online', $buddy['online']), theme_remove_from_buddylist_link($buddy['uid']));

You should not call theme_remove_from_buddylist_link directly as that circumvents the theme system - call theme('remove_from_buddylist_link'...... instead

I'd prefer not to pad out content with break tags - we should control padding with CSS and if the content is not in a container to make that possible we need to fix that.

I think your change to theme_remove_from_buddylist_link is wrong - you need to pass the $buddyuser->uid as the last part of the url.

Thanks