There are a large number of variables that are only used in tests for tracking a test's state. These should be moved to the new state system (#1175054: Add a storage (API) for persistent non-configuration state) when it gets committed. These conversions should be very simple, therefore I am marking this as novice. Documentation on converting variables to the state system can be found at http://drupal.org/node/1787318.

Here is a list of those I have found, although it may not be complete

Variable name File found in Issue Notes
batch_test_stack batch_test.module #1843410: Change variable batch_test_stack to the state system.
block_test_caching block_test.module #1843420: Change block test variables - block_test_cache and block_test_content to state system
block_test_content block_test.module #1843420: Change block test variables - block_test_cache and block_test_content to state system
common_test_cron system.test
dependencies system_test.module #1843442: Change the dependencies variable to the state system
dependency_test module_test.module #1843452: Change dependency_test variable to state system.
entity_cache_test entity.test #1843462: Change entity_test variables - entity_test_translation, entity_cache_test and entity_cache_test_label to the state system.
entity_cache_test_label entity_cache_test_dependency.module #1843462: Change entity_test variables - entity_test_translation, entity_cache_test and entity_cache_test_label to the state system.
entity_test_translation entity_test.module #1843462: Change entity_test variables - entity_test_translation, entity_cache_test and entity_cache_test_label to the state system.
field_test_bundles field_test.entity.inc #1843476: Change field_test variables to state system.
field_test_field_available_languages_alter field_test.module #1843476: Change field_test variables to state system.
field_test_language_fallback field_test.module #1843476: Change field_test variables to state system.
field_test_storage_data field_test.storage.inc #1843476: Change field_test variables to state system.
file_test_hook_file_url_alter file_test.module #1843486: Change file_test variables to state system.
file_test_results file_test.module #1843486: Change file_test variables to state system.
file_test_return file_test.module #1843486: Change file_test variables to state system.
front_page_output system_test.module #1848058: Change system test variables to the state system
image_test_results image_test.module #1848058: Change system test variables to the state system
language_test_content_language_type language_test.module #1843948: Change language test variables to the state system.
language_test_domain language_test.module #1843948: Change language test variables to the state system.
language_test_language_negotiation_info language_test.module #1843948: Change language test variables to the state system.
language_test_language_negotiation_info_alter language_test.module #1843948: Change language test variables to the state system.
language_test_language_negotiation_last LanguageNegotiationInfoTest.php #1843948: Change language test variables to the state system.
language_test_language_types language_test.module #1843948: Change language test variables to the state system.
menu_test_active_trail_initial menu.test #1843954: Change menu test variables to the state system.
menu_test_hook_custom_theme_name menu_test.module #1843954: Change menu test variables to the state system.
menu_test_menu_tree_set_path menu_test.module #1843954: Change menu test variables to the state system.
menu_test_record_active_trail menu_test.module #1843954: Change menu test variables to the state system.
openid_test_canonical_id_status openid_test.module #1848054: Change openid test variables to the state system.
openid_test_hook_openid_response_account OpenIDFunctionalTest.php #1848054: Change openid test variables to the state system.
openid_test_hook_openid_response_response OpenIDFunctionalTest.php #1848054: Change openid test variables to the state system.
openid_test_identity #1848054: Change openid test variables to the state system.
openid_test_redirect_http_reponse_code openid_test.module #1848054: Change openid test variables to the state system. the misspelling is in core
openid_test_redirect_url openid_test.module #1848054: Change openid test variables to the state system.
openid_test_request_alter #1848054: Change openid test variables to the state system.
openid_test_response #1848054: Change openid test variables to the state system.
path_test_results path.test #1848058: Change system test variables to the state system
simpletest_bootstrap_variable_test bootstrap.test #1848058: Change system test variables to the state system
test_module_enable_order system.test #1848058: Change system test variables to the state system
test_verbose_module_hooks system_test.module #1848058: Change system test variables to the state system
xmlrpc_test_xmlrpc_alter xmlrpc_test.module #1848066: Change variable xmlrpc_test_xmlrpc_alter to the state system.
Files: 
CommentFileSizeAuthor
#21 drupal-convert_test_vars_to_state_system-1787218-19.patch72.73 KBdisasm
FAILED: [[SimpleTest]]: [MySQL] 46,189 pass(es), 55 fail(s), and 20 exception(s).
[ View ]
#20 drupal-convert_test_vars_to_state_system-1787218-19.patch72.73 KBdisasm
FAILED: [[SimpleTest]]: [MySQL] 46,186 pass(es), 47 fail(s), and 16 exception(s).
[ View ]
#18 drupal-convert_test_vars_to_state_system-1787218-18.patch72.16 KBdisasm
FAILED: [[SimpleTest]]: [MySQL] 46,185 pass(es), 49 fail(s), and 19 exception(s).
[ View ]
#13 convert-test-vars-to-state-system-1787218-13.patch72.23 KBdags
FAILED: [[SimpleTest]]: [MySQL] 41,335 pass(es), 48 fail(s), and 16 exception(s).
[ View ]
#13 interdiff.txt6.23 KBdags
#10 convert-test-vars-to-state-system-1787218-4.patch71.44 KBsamhassell
FAILED: [[SimpleTest]]: [MySQL] 33,561 pass(es), 462 fail(s), and 217 exception(s).
[ View ]
#6 convert-test-vars-to-state-system-1787218-3.patch71.49 KBsamhassell
FAILED: [[SimpleTest]]: [MySQL] Invalid PHP syntax in core/modules/system/tests/modules/image_test/image_test.module.
[ View ]
#4 convert-test-vars-to-state-system-1787218-2.patch71.49 KBsamhassell
FAILED: [[SimpleTest]]: [MySQL] Invalid PHP syntax in core/modules/system/lib/Drupal/system/Tests/Bootstrap/VariableTest.php.
[ View ]
#1 convert-test-vars-to-state-system-1787218-1.patch71.49 KBsamhassell
FAILED: [[SimpleTest]]: [MySQL] Invalid PHP syntax in core/modules/block/tests/block_test.module.
[ View ]

Comments

Issue summary:View changes

Updated issue summary.

StatusFileSize
new71.49 KB
FAILED: [[SimpleTest]]: [MySQL] Invalid PHP syntax in core/modules/block/tests/block_test.module.
[ View ]

First run at this hitting all the listed vars. No time to test it yet.

Status:Active» Needs review

Status:Needs review» Needs work

The last submitted patch, convert-test-vars-to-state-system-1787218-1.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new71.49 KB
FAILED: [[SimpleTest]]: [MySQL] Invalid PHP syntax in core/modules/system/lib/Drupal/system/Tests/Bootstrap/VariableTest.php.
[ View ]

try again.

Status:Needs review» Needs work

The last submitted patch, convert-test-vars-to-state-system-1787218-2.patch, failed testing.

StatusFileSize
new71.49 KB
FAILED: [[SimpleTest]]: [MySQL] Invalid PHP syntax in core/modules/system/tests/modules/image_test/image_test.module.
[ View ]

Status:Needs work» Needs review

Status:Needs review» Needs work

The last submitted patch, convert-test-vars-to-state-system-1787218-3.patch, failed testing.

Note that the state system has not actually been committed yet, so this will continue to fail until that happens. The patch is still really useful though, it just can't be finished until the other issue goes in. Thanks for working on it!

StatusFileSize
new71.44 KB
FAILED: [[SimpleTest]]: [MySQL] 33,561 pass(es), 462 fail(s), and 217 exception(s).
[ View ]

Never doing this without a testing environment again.. If it fails I'll come back tomorrow and fix.

Status:Needs work» Needs review

Status:Needs review» Needs work

The last submitted patch, convert-test-vars-to-state-system-1787218-4.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new6.23 KB
new72.23 KB
FAILED: [[SimpleTest]]: [MySQL] 41,335 pass(es), 48 fail(s), and 16 exception(s).
[ View ]

Replace "state()->del" with "state()->delete" and fix a couple missed conversions.

Status:Needs review» Needs work
Issue tags:-Configuration system, -Config novice

The last submitted patch, convert-test-vars-to-state-system-1787218-13.patch, failed testing.

Status:Needs work» Needs review

Status:Needs review» Needs work
Issue tags:+Configuration system, +Config novice

The last submitted patch, convert-test-vars-to-state-system-1787218-13.patch, failed testing.

I did not see this issue prior to opening #1814402: Convert 'node_access_test_private' variable to state() system. However, it was not included in the list in the summary.

Also opened #1813184: Convert variable 'tracker_index_nid' to state system for 'tracker_index_nid' variable conversion.

StatusFileSize
new72.16 KB
FAILED: [[SimpleTest]]: [MySQL] 46,185 pass(es), 49 fail(s), and 19 exception(s).
[ View ]

Here's a reroll of #13.

Status:Needs work» Needs review

StatusFileSize
new72.73 KB
FAILED: [[SimpleTest]]: [MySQL] 46,186 pass(es), 47 fail(s), and 16 exception(s).
[ View ]

The block test was a quick fix. Attached. Still failing OpenID and variable tests. The variable tests is going to need some refactoring (or maybe removal). It currently has a menu hook that that has a callback of variable_get in the system_test module.

StatusFileSize
new72.73 KB
FAILED: [[SimpleTest]]: [MySQL] 46,189 pass(es), 55 fail(s), and 20 exception(s).
[ View ]

The block test was a quick fix. Attached. Still failing OpenID and variable tests. The variable tests is going to need some refactoring (or maybe removal). It currently has a menu hook that that has a callback of variable_get in the system_test module.

Status:Needs review» Needs work

The last submitted patch, drupal-convert_test_vars_to_state_system-1787218-19.patch, failed testing.

Issue summary:View changes

Updated issue summary.

I think it makes more sense to tackle these variables with separate issues, particularly with some already having been done. I've made a start.

Issue summary:View changes

Adding issue to batch_test_stack

Issue summary:View changes

Added issue for the block test variables.

Issue summary:View changes

Add issue for dependencies

Issue summary:View changes

Add issue for dependency test.

Issue summary:View changes

Add issue for entity test variables.

Issue summary:View changes

Add issue to field test variables.

Issue summary:View changes

Issue for file test variables.

Issue summary:View changes

Language variables issue.

Issue summary:View changes

Menu test variables.

Issue summary:View changes

open id issue added

Issue summary:View changes

system test variables

Status:Needs work» Closed (duplicate)

I thought it might be easy to do this all in one shot, but if some are already being worked on elsewhere I'll just close this one I guess. Lets make sure and keep #1775842: [meta] Convert all variables to state and/or config systems up to date.

Issue summary:View changes

xmlprc variable added.