Black Swan [#1788704]

A simple Black theme based on Fluid 960.gs

Source Repo: git clone --recursive --branch 7.x-1.x http://git.drupal.org/sandbox/pradbabu/1788652.git black_swan

Drupal core: 7.x

Comment	File	Size	Author
#5	error.txt	559 bytes	zymphonies-dev
#5	contact.png	27.77 KB	zymphonies-dev
#5	blog.png	23.46 KB	zymphonies-dev
#5	font_color.png	22.82 KB	zymphonies-dev
#4	bug.jpg	75.78 KB	ketelagoreng
	blackswan-screenshot.png	230.51 KB	pradbabu

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

pradbabu CreditAttribution: pradbabu commented 19 September 2012 at 08:09

Status:

Needs review

» Postponed

Comment #2

pradbabu CreditAttribution: pradbabu commented 19 September 2012 at 08:38

Status:

Postponed

» Needs review

Comment #3

lakshminp CreditAttribution: lakshminp commented 21 September 2012 at 04:56

Status:

Needs review

» Needs work

Hi pradbabu,

You need to change your comment to:
git clone --recursive --branch 7.x-1.x http://git.drupal.org/sandbox/pradbabu/1788652.git black_swan

instead of

git clone --recursive --branch 7.x-1.x pradbabu@git.drupal.org:sandbox/pradbabu/1788652.git black_swan.

Also, run through the code review checklist before submitting.

http://ventral.org/pareview/httpgitdrupalorgsandboxpradbabu1788652git-7x-1x

good luck.

Comment #4

ketelagoreng CreditAttribution: ketelagoreng commented 24 September 2012 at 09:22

File	Size
bug.jpg	75.78 KB

hi pradbabu,
I get a serious problem here. Look a pic I attached.

Comment #5

zymphonies-dev CreditAttribution: zymphonies-dev commented 20 November 2012 at 09:03

File	Size
font_color.png	22.82 KB
blog.png	23.46 KB
contact.png	27.77 KB
error.txt	559 bytes

HI,
Manual review
1) You have used same color for site name, all menus, etc
Please give different color for site name
2) Blog elements are not aligned properly
3) Add form item, form actions global style

.form-item, .form-actions {
    margin-bottom: 1em;
    margin-top: 1em;
}
Attached all screenshots and code sniffer errors

Comment #6

klausi

he/him||they/them

German

🇦🇹 Vienna

CreditAttribution: klausi commented 29 January 2013 at 21:15

Status:

Needs work

» Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

If you reopen this please keep in mind that we are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)