The current code has many hardcoded calls to the ImageCrop constructor like $imagecrop = new ImageCrop(); It would be nice if other modules could replace that class with their own implementation.

CommentFileSizeAuthor
#5 imagecrop-alterclass-1790224-5.patch1.82 KBdiscipolo
#3 imagecrop-class-pluggable-1790224-3.patch3.26 KBc31ck
#2 imagecrop-class-pluggable-1790224-2.patch3.27 KBc31ck
#1 imagecrop-class-pluggable.patch3.26 KBc31ck
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

c31ck’s picture

c31ck CreditAttribution: c31ck commented
Status: Active » Needs review
FileSize
imagecrop-class-pluggable.patch3.26 KB

Patch that adds a wrapper function imagecrop_get_instance() around the constructor calls. Other modules can implement hook_imagecrop_class_alter() to return their own class.

c31ck’s picture

c31ck CreditAttribution: c31ck commented
FileSize
imagecrop-class-pluggable-1790224-2.patch3.27 KB

Rerolled against HEAD.

c31ck’s picture

c31ck CreditAttribution: c31ck commented
FileSize
imagecrop-class-pluggable-1790224-3.patch3.26 KB

Better patch.

ianthomas_uk’s picture

ianthomas_uk
he/him
Primary language English
Location Brighton, UK
CreditAttribution: ianthomas_uk commented
Issue summary: View changes
Related issues: +#2101757: Cropping creates black area in cropped image
discipolo’s picture

discipolo CreditAttribution: discipolo commented
Status: Needs review » Reviewed & tested by the community
FileSize
imagecrop-alterclass-1790224-5.patch1.82 KB

here is one that applies to projects[imagecrop][download][revision] = 98d1faa

ianthomas_uk’s picture

ianthomas_uk
he/him
Primary language English
Location Brighton, UK
CreditAttribution: ianthomas_uk commented
Status: Reviewed & tested by the community » Needs review

Please don't set your own patches to RTBC (see https://www.drupal.org/node/156119 for more info on issue statuses).