Panelizer panel select tab (activated with 'allow panel choice') not appearing when adding a node.

Same issue here

Hello there,
Me too have a problem. I enabled allow multiple panel layout and created three templates. But when i create a node there is no option appearing t hat allow me to choose from various panelized template. But surprisingly when i use panoply drupal distribution there it works. So if you really need that feature i advice choose panoply for now or upgrade an existing one to panoply distribution.

Thanks and Regard
Gaurav Sharma

Same issue here.
As far as I can tell the issue has two parts:

1. PanelizerEntityDefault::hook_entity_load() uses PanelizerEntityDefault::has_default_panel() instead PanelizerEntityDefault::is_panelized() to determine whether it has to deal with defaults
2. PanelizerEntityDefault::hook_field_attach_form() hides the vertical tab based on the last view mode processed in the loop and not per view mode. Correct would be to define the access per widget and the access to the vertical tab is granted as soon as one of the widgets is accessible.

The attached patch does the necessary changes to fix the issues mentioned above.

It looks like this patch uncovered another issue.
panelizer_panels_cache_get() calls panels_common_get_allowed_layouts(), unfortunately panels_common_get_allowed_layouts() doesn't ensure that the panels plugin is loaded (ctools_include('plugins', 'panels');).
Thus you can end up with a fatal error that complains that the function panels_get_layouts() couldn't be found.

I've added ctools_include('plugins', 'panels'); to panelizer_panels_cache_get() in the updated patch to ensure the plugin is really available.
However, I'm not sure if this not better should be part of panels_common_get_allowed_layouts() instead.

Added other adjustments:

• PanelizerEntityDefault::has_panel_choice() didn't properly call PanelizerEntityDefault::is_panelized. It was called with the bundle only even if a view mode was given.
• Added exception to PanelizerEntityDefault::panelizer_access() for choice, similar to settings and overview. Needs review!

Hmm.. It was hard to apply this patch (twice), rerolled against the latest dev.
It works as well, if on content type settings Provide default panel is checked.
If not, then add a new node without panel, save, and edit, the default panel is set as 'default'. It means, if when a node was saved with panelizer, there isn't any chance to "depanelize" it.

yep, forgot the patch.

I did a review of this patch and it solves the problem I was seeing of the Panel Choice tab not showing up. The patch code looks straight forward enough, but might need another set of eyes.

          // If no panelizer was loaded for the view mode, queue up defaults.
-        if (empty($panelizers[$entity_id][$view_mode]) && $this->has_default_panel($bundles[$entity_id] . '.' . $view_mode)) {
+        if (empty($panelizers[$entity_id][$view_mode]) && $this->is_panelized($bundles[$entity_id] . '.' . $view_mode)) {
           $defaults[$name] = $name;
         }
         // Otherwise unpack the loaded panelizer.

This part of the patch does not make sense to me. If there isn't a default (which is possible; if there is 'choice' and no 'default' then the default state is not panelized) we shouldn't be trying to load something. Please explain this change to me?

The above is particularly true because the reproduction instructions have you select "has default", so changing that test is very different from the reproduction instructions.

Here is a more basic patch that just allows the selection box to be added.

I tested this new patch with the following conditions and it works fine:

1.) Create a content type that is Panelized with multiple options

2.) When creating node select an option and make sure the specified layout/content configuration exists

3.) Switch the option later (if the page isn't overriddeN0

Committed and pushed #12.

There are some pieces of the original patch that seem like they might be legitimate bug fixes in other areas. These should not be lost, but I need more information about what they are fixing.

I don't know what information I should deliver. I've wrote down what and why I did in each post. However, all the changes I made were based on assumptions I made about how panelizer works, not on qualified knowledge.
So, let me know how I can provide the information needed and I'll do so.