The helper function _media_recursive_check_plain() is defined and used in media.browser.inc but is also used in media.media.inc. Unfortunately, it seems that media.browser.inc is not always loaded which can lead to errors, namely (when searching for files in the media browser):

Warning: array_walk_recursive() expects parameter 2 to be a valid callback, function '_media_recursive_check_plain' not found or invalid function name in media_query_media_browser_alter() (line 55 of /Users/devin/Sites/acquia-drupal/sites/all/modules/media/media.media.inc).

The _media_recursive_check_plain() function should be moved out of media.browser.inc and into media.module where it will always be available.

Files: 
CommentFileSizeAuthor
#1 move-and-rename-function-1790448-1.patch2.12 KBDevin Carlson
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch move-and-rename-function-1790448-1.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Comments

Status:Active» Needs review
StatusFileSize
new2.12 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch move-and-rename-function-1790448-1.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

A patch to move the function into media.module. I've also removed the leading underscore from the function name, as it doesn't really seem like a helper function since it is used in multiple locations.

Status:Needs review» Reviewed & tested by the community

Looks good to me.

Thanks, seems patch works, no more entries in dblog

Status:Reviewed & tested by the community» Fixed

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.