Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
We should copy the indexable bundles (those that were selected by the user) to the newly enabled acquia search environment so the transition from a self-hosted to Acquia Search index is as smooth as possible.
This issue is in line with #1783796: We should manage excluded, not indexed, bundles and #1790894: Cloning an environment doesn't clone the bundles to be indexed
Comment | File | Size | Author |
---|---|---|---|
#22 | 1791338-21-fu.patch | 1.92 KB | pwolanin |
#21 | 1791338-20-fu.patch | 1.19 KB | pwolanin |
#20 | 1791338-19-fu.patch | 705 bytes | pwolanin |
#14 | 1791338-13.patch | 4.39 KB | pwolanin |
#13 | 1791338-12.patch | 4.27 KB | Nick_vh |
Comments
Comment #1
Nick_vhComment #2
pwolanin CreditAttribution: pwolanin commentedre:
We shouldn't do that unless 'solr' exists as an environment. If it doesn't we might need to re-create it.
Comment #3
Nick_vhTested this patch - just don't like the fact that I have to replicate some code from the main module - but it's not a big deal.
Also, we are now depending on the latest dev version of apachesolr since i am referring to the clear cache function. Make sure you include that in the release notes
Comment #4
Nick_vhlet's get the testbot some work
Comment #5
Nick_vhsecond try. I'm depending on a clear cache function here, I should probably not do that
Comment #6
Nick_vhDecided I should not depend on a function that is not there in previous versions
Comment #7
pwolanin CreditAttribution: pwolanin commentedLooks better- I agree we shouldn't depend on new functions.
Comment #8
pwolanin CreditAttribution: pwolanin commenteddid - manual testing of the 3 scenarios all behaves as expected.
Comment #9
cpliakas CreditAttribution: cpliakas commented#6: 1791338-6.patch queued for re-testing.
Comment #10
cpliakas CreditAttribution: cpliakas commentedI can't apply the patch to test.
Comment #12
pwolanin CreditAttribution: pwolanin commentedre-rolled. Intervening commit made the 1st hunk not apply.
Comment #13
Nick_vhComment #14
pwolanin CreditAttribution: pwolanin commentedRemoved a change I shouldn't have.
Comment #15
Nick_vhthis should not be removed?
Comment #16
cpliakas CreditAttribution: cpliakas commentedIt shouldn't. Makes me wonder why the testbot didn't pick this up since I wrote tests for this. Might have to revisit that as well.
EDIT: NM, it did pick it up for the patch in #12. Go test bot!
Comment #17
pwolanin CreditAttribution: pwolanin commentedIt did pick it up - that's why #12 fails.
In #14 it's just moved to the bottom of the function - I think it makes more sense to set it after the env is fully set up.
Comment #18
pwolanin CreditAttribution: pwolanin commentedcommitted. needs to be backported to acquia_search 6.x-3.x:
#1791638: Copy the index_bundles from the previous default environment to the new acquia_search environment
Comment #19
cpliakas CreditAttribution: cpliakas commentedAdding two related testing tasks that shouldn't hold up any releases.
#1791646: Add tests for copying the index_bundles from the previous default environment to the new acquia_search environment
#1791642: Add tests for the expected behavior when the Acquia Search module is disabled
Comment #20
pwolanin CreditAttribution: pwolanin commentedActually, looking at the code it seems like there is no reason to change the default environment if it points to a cloned env.
Comment #21
pwolanin CreditAttribution: pwolanin commentedHmm, I'm not sure why that prior code was working - it seems like it was setting bundles for the wrong env ID.
Comment #22
pwolanin CreditAttribution: pwolanin commentedMaybe safer, API-wise, to delete the env after we check whether it's the default?
Comment #23
pwolanin CreditAttribution: pwolanin commentedcommitted