Business-Enterprise

Hi Shanidkv,

1) Please change "shanidkv@git.drupal.org:sandbox/shanidkv/1781600.git" to
http://git.drupal.org/sandbox/shanidkv/1781600.git

2. As per http://drupal.org/node/1015226, master branch should not be used. Create a branch named '7.x-1.x' and you can work on it.

3. Also, running your code through automated code review:
http://ventral.org/pareview/httpgitdrupalorgsandboxshanidkv1781600git

4. It would be great, if you could upload a screenshot of your theme in the page.

5. There is a file 'desktop.ini' in your repository. Please remove it or ignore it, before committing.

6. It's a best practice to attribute the source for images used, and the superfish plugins used.

+1, Looks good ! Marking as RTBC.

Came across couple of Javascript errors found using firebug. Needs to be fixed !

Uncaught SyntaxError: Unexpected token ) superfish.js:35
Uncaught TypeError: Object #

Restoring project application status.

We are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

Nice job. Marking as RTBC.

Removing review bonus tag, you have not done any manual review, you just posted the output of an automated review tool. Make sure to read through the source code of the other projects.

• Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

manual review:

1. You must have committed something big to your repository in the past - git clone takes really long. Where do the 21 MB come from?
2. slides.min.jquery.js appears to be 3rd party code. 3rd party code is not generally allowed on Drupal.org and should be deleted. This policy is described in the getting involved handbook. It also appears in the terms and conditions you agreed to when you signed up for Git access, which you may want to re-read, to be sure you're not violating other terms. The Libraries API module is a recommended method for adding 3rd party dependencies without directly including the code on Drupal.org. Same for superfish.js.
3. business_enterprise_html_head_alter(): this is a hook implementation and should be documented as such, see http://drupal.org/node/1354#hookimpl . Please fix the doc blocks on all your hook implementations.
4. page.tpl.php: this is vulnerable to XSS exploits. If I enter "><script>alert('XSS');</script> as twitter of facebook user name in the theme settings I get a nasty javascript popup. You need to sanitize user provided input before printing. Please read http://drupal.org/node/28984 again.

Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

From your screenshot, it looks like you have a typo where you are trying to push to 7xx-1.x, but your git repo in your sandbox has a branch that is called 7.x-1.x

What does the output of git remote -v show?

You're trying to push over http, and I suspect you are using a non-maintainer. You need to use your maintainer link which should have the format of shanidkv@git.drupal.org:sandbox/shanidkv/1781600.git

You've cloned the public and can't push to that. You need to use the maintainer link for your origin.

Do this:

git remote rm origin
git remote add origin shanidkv@git.drupal.org:sandbox/shanidkv/1781600.git 
git push origin 7.x-1.x

Edit:
To answer your question about git remote -v, it shows where your remote is. Origin is a shortcut so you don't have to type the full address. It tells you how you are authenticating and what origin is actually linked to.

You must have had some binary files or something in your repo at one point. I do remember when I cloned your repo, it took a long time.

This might help shed some light on your issue:http://stackoverflow.com/questions/1029969/why-is-my-git-repository-so-big

There is still a master branch, make sure to set the correct default branch: http://drupal.org/node/1659588 . Then remove the master branch, see also step 6 and 7 in http://drupal.org/node/1127732
Review of the 7.x-1.x branch:

• Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

manual review:

1. there are two info files in the repository?
2. business_enterprises_form_alter(): this is a hook implementation and should be documented as such, see http://drupal.org/node/1354#hookimpl . Please fix the doc blocks on all your hook implementations.

But that are not blockers, otherwise looks RTBC to me. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

No objections for more than a week, so ...

Thanks for your contribution, shanidkv!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.