Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.The patch added in commit 8b95c77 changes the logic that generates the host for the Acquia Search environment. Therefore it would be a great candidate for test coverage to ensure that it works as expected. It might also be worth pulling out the host generation code into a separate, smaller function to facilitate better testing.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | host-tests-1791904-1.patch | 4.14 KB | cpliakas |
Comments
Comment #1
cpliakas CreditAttribution: cpliakas commentedInitial crack at refactoring the code for testing. By separating it out this way, we can test the url generation via the speedy Unit tests without having to create a new database in order to get the system variables. Also taking the opportunity to improve the documentation so there is more transparency as to what the code is doing.
Marking as needs work because I haven't validated that the code works, and there are no tests.
Comment #2
Dane Powell CreditAttribution: Dane Powell at Acquia commentedThis branch of Acquia Connector is no longer supported, per the version policy on the project homepage. As such, I'm tentatively closing this issue.
If this issue still applies to a supported branch (currently 7.x-3.x, 8.x-1.x, or 8.x-2.x), please reopen and select the new target version. Thanks!