See #1781744: Draft and Needs review pages are broken for details and the workbench moderation patch.

Files: 
CommentFileSizeAuthor
#32 1792144-workbench-myedits-view.patch16.94 KBhass
PASSED: [[SimpleTest]]: [MySQL] 0 pass(es).
[ View ]
#27 workbench_edited_views-1792144-27.patch11.81 KBasunko
PASSED: [[SimpleTest]]: [MySQL] 0 pass(es).
[ View ]
#27 workbench_module-1792144-27.patch564 bytesasunko
PASSED: [[SimpleTest]]: [MySQL] 0 pass(es).
[ View ]
#27 workbench_access-1792144-27-do-not-test.patch840 bytesasunko
#27 workbench_moderation-1792144-27-do-not-test.patch591 bytesasunko
#25 workbench_edited-1792144-25.view_.inc_.patch11.03 KBasunko
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch workbench_edited-1792144-25.view_.inc_.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#20 1792144-myedits-view.patch16.94 KBagentrickard
PASSED: [[SimpleTest]]: [MySQL] 0 pass(es).
[ View ]
#4 workbench.patch6.21 KBhass
PASSED: [[SimpleTest]]: [MySQL] 0 pass(es).
[ View ]
#3 workbench.patch6.21 KBhass
PASSED: [[SimpleTest]]: [MySQL] 0 pass(es).
[ View ]
workbench.patch6.21 KBhass
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch workbench_0.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Comments

Status:Needs review» Needs work

The last submitted patch, workbench.patch, failed testing.

Version:7.x-1.1» 7.x-1.x-dev
Status:Needs work» Needs review

StatusFileSize
new6.21 KB
PASSED: [[SimpleTest]]: [MySQL] 0 pass(es).
[ View ]

StatusFileSize
new6.21 KB
PASSED: [[SimpleTest]]: [MySQL] 0 pass(es).
[ View ]

@tkngdwn: Your patch is working great for me! THX!!!

This patch is applied against 7.x-1.x-dev, can we get a patch for 7.x-1.1?

I have installed latest dev+patch and it fixed all. Dev looks stable... Just try it. There are no db changes. You may downgrade if all goes wrong.

Could we get a patch for the 7.x-1.1?
Thank you very much in advance!

Patch in #4 works fine for me on dev. Thank you!

The reason people are asking for a 1.1 patch is because the dev version is not available for download.
You need to use git or drush to get it.

Status:Needs review» Needs work

btw
With this patch, my workbench / my edits view now shows all content you edited (which is logical) but links to the content version instead of the node view (even on unversioned content)

So instead of "Link this field to its content revision" I chose "Link this field to the original piece of content" to fix it

This seems like a bug, so setting to "needs work".

Seems like the following issue is resolved by the patch here:
#1630702: My Edits list contains multiple dupes

There are two typos for node_revision.

http://drupal.org/node/1735382

This worked for me. Thank you

Comment #12 creates a circular issue reference. Let's stay here. The other issue is closed.

@agendrickard: looks like you have co-maintainer permission. Are you able to review this and the moderation patch and get them committed? Both modules are not usable at all without. We need new releases asap.

hass, What's your opinion on #11? This issue is marked as "needs work."

I have not tested this. I have the hope that the maintainers knows best.

@hass

What moderation patch?

This one #1781744: Draft and Needs review pages are broken. Same topic, but only contains the Workbench part. Also critical.

Status:Needs work» Needs review
StatusFileSize
new16.94 KB
PASSED: [[SimpleTest]]: [MySQL] 0 pass(es).
[ View ]

In the -dev version, I'm not seeing this error anymore, which suggests that it has been fixed in Views.

I am seeing, however, two related issues:

Duplicate entries in the My Edits list.
Bad links to access denied on revisions.

This patch, I believe, incorporates the changes from #4 and also fixes those errors. Tested with Workbench 1.x-dev and Views 3.x-dev.

Patch from #20 works for me. Thanks,

It looks like #1766338: Regression: Incorrect filter group OR behavior, LEFT JOIN changed to INNER JOIN is not yet fixed in Views and some thought this may be a reason.

As in "a reason why I just added an extra filter to correct duplicate records"?

No, it looks like a possible root cause for the original report in this case. I clicked trough all commit messages and until now (back to mid sept) I have not found any views commits to 7.x that may explain why the issue should be fixed. Just as a note. Haven't tried yet a views DEV.

StatusFileSize
new11.03 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch workbench_edited-1792144-25.view_.inc_.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Status:Needs review» Needs work

The last submitted patch, workbench_edited-1792144-25.view_.inc_.patch, failed testing.

StatusFileSize
new591 bytes
new840 bytes
new564 bytes
PASSED: [[SimpleTest]]: [MySQL] 0 pass(es).
[ View ]
new11.81 KB
PASSED: [[SimpleTest]]: [MySQL] 0 pass(es).
[ View ]

I have same problem that describe in this issue. These patches have helped to correct the work of three modules workbench 7.x-1.1, workbench access 7.x-1.0, workbench moderation 7.x-1.2 with module Views 7.x-3.5. I posted all of the patches in this issue. it works for me.
There are two options how to fix the problem of incompatibility workbench 7.x-1.1 and Views 7.x-3.5
Use one of them workbench_edited_views-1792144-27.patch or workbench_module-1792144-27.patch. The other two for workbench access 7.x-1.0 and workbench moderation 7.x-1.2 respectively.

These patches are for those who can't update listed above modules to dev version where I suppose this problem was fixed.

Version:7.x-1.x-dev» 7.x-1.1
Category:bug» support
Priority:Critical» Normal
Status:Needs work» Needs review

@annasunko

Why did you do the following?

* Post multiple patches without any comment?
* Change the issue status?
* Change this to a support request?
* NOT REVIEW THE EXISTING PATCH?

While your intent may be to help, you are only confusing the issue.

Version:7.x-1.1» 7.x-1.x-dev
Category:support» bug
Priority:Normal» Critical
Status:Needs review» Needs work

@agentrickard
* Change the issue status?
* Change this to a support request?
Accidentally. The status has been returned.

Thanks.

The real blocker here is figuring out where these issues have been fixed (presumably in Views). My concern is that these patches will just break things again when a new Views release comes out.

Status:Reviewed & tested by the community» Needs work

@agentrickard: I'm running all modules (views, workbench, workbench_moderation, workbench_access) in latest DEV and I still see:

Debug:

'Handler views_handler_field_node_revision tried to add additional_field language but node could not be added!'

in views_handler_field->add_additional_fields() (line 142 of sites\all\modules\views\handlers\views_handler_field.inc).

I'm not sure why your don't see this. Are you using taxonomy for permissions?

Status:Needs work» Reviewed & tested by the community
StatusFileSize
new16.94 KB
PASSED: [[SimpleTest]]: [MySQL] 0 pass(es).
[ View ]
  • Duplicate entries in the My Edits list.
  • Bad links to access denied on revisions.

Should we show unpublished, but edited content in the my edits list? I'm not sure. Otherwise the patch #20 from agentrickard also fixes the debug message. I'm marking RTBC now.

Re-attaching the patch #20 to remove the confusing failures from annasunko and get the green light again.

Status:Needs work» Reviewed & tested by the community
Issue tags:+Workbench Sprint

Are there no tests for Workbench? The test result is saying 0 passes, which makes me think "broken patch" (this happens in the core queue sometimes).

No, there are no tests yet. It just tests if the patch applies cleanly, has no unix line feeds and some other basic tests.

But you can write some tests... :-)

Workbench proper doesn't do much, so it has no tests. If there are good methods for testing that Views work, they could be applied here.

Title:Handler workbench_access_handler_field_section tried to add additional_field nid but node could not be added!"My Edits" View is broken

Fixed. Thanks hass et al!

cweagans, "Workbench" does not have any tests, correct. Alone it does not do much. Workbench Moderation and Workbench Access do more of the heavily lifting and have some test coverage. That being said, tests on Workbench itself are welcome.

http://drupalcode.org/project/workbench.git/commit/85b13bbdb283fe6d910ac...

Status:Reviewed & tested by the community» Fixed

Great!

After updating via Git and re-installing, I can no longer see the "Sections" column when using Workbench Access. But I see the filter.

Anyone seeing that?

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue summary:View changes

A